Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2397943003: Revert of Delete webrtc::VideoFrame::CopyFrame. (Closed)

Created:
4 years, 2 months ago by ivoc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete webrtc::VideoFrame::CopyFrame. (patchset #2 id:20001 of https://codereview.webrtc.org/2371363003/ ) Reason for revert: This CL breaks internal dependencies. Original issue's description: > Delete webrtc::VideoFrame::CopyFrame. > > BUG=webrtc:5682 > > Committed: https://crrev.com/0e7c7ce35d9449c5bb13328d1bfb04ad32e48ccc > Cr-Commit-Position: refs/heads/master@{#14550} TBR=magjed@webrtc.org,tommi@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Committed: https://crrev.com/21a18ee267146c86e188d95edf6432f71dd53aeb Cr-Commit-Position: refs/heads/master@{#14553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -6 lines) Patch
M webrtc/common_video/i420_video_frame_unittest.cc View 2 chunks +44 lines, -0 lines 0 comments Download
M webrtc/common_video/video_frame.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video_frame.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ivoc
Created Revert of Delete webrtc::VideoFrame::CopyFrame.
4 years, 2 months ago (2016-10-06 13:29:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2397943003/1
4 years, 2 months ago (2016-10-06 13:29:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 13:29:33 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/21a18ee267146c86e188d95edf6432f71dd53aeb Cr-Commit-Position: refs/heads/master@{#14553}
4 years, 2 months ago (2016-10-06 13:29:38 UTC) #6
nisse-webrtc
4 years, 2 months ago (2016-10-20 07:37:46 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2435963002/ by nisse@webrtc.org.

The reason for reverting is: Dependencies updated..

Powered by Google App Engine
This is Rietveld 408576698