Chromium Code Reviews

Issue 2397673002: Revert of Delete unused code httprequest, httpclient, and socketpool. (Closed)

Created:
4 years, 2 months ago by ivoc
Modified:
4 years, 2 months ago
Reviewers:
nisse-webrtc, perkj_webrtc, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete unused code httprequest, httpclient, and socketpool. (patchset #3 id:40001 of https://codereview.webrtc.org/2366333002/ ) Reason for revert: This CL breaks some downstream dependencies (contact me for more info). Original issue's description: > Delete unused code httprequest, httpclient, and socketpool. > > BUG=webrtc:6424 > > Committed: https://crrev.com/4a255be3790a040cae2f6182ed70b7dd38c6839e > Cr-Commit-Position: refs/heads/master@{#14514} TBR=perkj@webrtc.org,pthatcher@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6424 Committed: https://crrev.com/3324cf751a03a5f085cb5e3b72948873323d6180 Cr-Commit-Position: refs/heads/master@{#14518}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+1696 lines, -0 lines)
M webrtc/base/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments
M webrtc/base/base.gyp View 2 chunks +6 lines, -0 lines 0 comments
A webrtc/base/httpclient.h View 1 chunk +196 lines, -0 lines 0 comments
A webrtc/base/httpclient.cc View 1 chunk +835 lines, -0 lines 0 comments
A webrtc/base/httprequest.h View 1 chunk +116 lines, -0 lines 0 comments
A webrtc/base/httprequest.cc View 1 chunk +114 lines, -0 lines 0 comments
A webrtc/base/socketpool.h View 1 chunk +143 lines, -0 lines 0 comments
A webrtc/base/socketpool.cc View 1 chunk +280 lines, -0 lines 0 comments

Messages

Total messages: 6 (2 generated)
ivoc
Created Revert of Delete unused code httprequest, httpclient, and socketpool.
4 years, 2 months ago (2016-10-05 08:23:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2397673002/1
4 years, 2 months ago (2016-10-05 08:23:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 08:23:19 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 08:23:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3324cf751a03a5f085cb5e3b72948873323d6180
Cr-Commit-Position: refs/heads/master@{#14518}

Powered by Google App Engine