Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: webrtc/media/base/mediaconstants.h

Issue 2397413002: - Filter data channel codecs based on codec name instead of payload type, which may have been remap… (Closed)
Patch Set: reviewer comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/webrtcsession_unittest.cc ('k') | webrtc/media/base/mediaconstants.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 // Google specific parameters 99 // Google specific parameters
100 extern const char kCodecParamMaxBitrate[]; 100 extern const char kCodecParamMaxBitrate[];
101 extern const char kCodecParamMinBitrate[]; 101 extern const char kCodecParamMinBitrate[];
102 extern const char kCodecParamStartBitrate[]; 102 extern const char kCodecParamStartBitrate[];
103 extern const char kCodecParamMaxQuantization[]; 103 extern const char kCodecParamMaxQuantization[];
104 extern const char kCodecParamPort[]; 104 extern const char kCodecParamPort[];
105 105
106 // We put the data codec names here so callers of 106 // We put the data codec names here so callers of
107 // DataEngine::CreateChannel don't have to import rtpdataengine.h or 107 // DataEngine::CreateChannel don't have to import rtpdataengine.h or
108 // sctpdataengine.h to get the codec names they want to pass in. 108 // sctpdataengine.h to get the codec names they want to pass in.
109 extern const int kGoogleRtpDataCodecId; 109 extern const int kGoogleRtpDataCodecPlType;
110 extern const char kGoogleRtpDataCodecName[]; 110 extern const char kGoogleRtpDataCodecName[];
111 111
112 // TODO(pthatcher): Find an id that won't conflict with anything. On 112 // TODO(pthatcher): Find an id that won't conflict with anything. On
113 // the other hand, it really shouldn't matter since the id won't be 113 // the other hand, it really shouldn't matter since the id won't be
114 // used on the wire. 114 // used on the wire.
115 extern const int kGoogleSctpDataCodecId; 115 extern const int kGoogleSctpDataCodecPlType;
116 extern const char kGoogleSctpDataCodecName[]; 116 extern const char kGoogleSctpDataCodecName[];
117 117
118 extern const char kComfortNoiseCodecName[]; 118 extern const char kComfortNoiseCodecName[];
119 119
120 extern const char kVp8CodecName[]; 120 extern const char kVp8CodecName[];
121 extern const char kVp9CodecName[]; 121 extern const char kVp9CodecName[];
122 extern const char kH264CodecName[]; 122 extern const char kH264CodecName[];
123 123
124 // RFC 6184 RTP Payload Format for H.264 video 124 // RFC 6184 RTP Payload Format for H.264 video
125 extern const char kH264FmtpProfileLevelId[]; 125 extern const char kH264FmtpProfileLevelId[];
(...skipping 11 matching lines...) Expand all
137 extern const int kDefaultRtxVp9PlType; 137 extern const int kDefaultRtxVp9PlType;
138 extern const int kDefaultRtxRedPlType; 138 extern const int kDefaultRtxRedPlType;
139 extern const int kDefaultRtxH264PlType; 139 extern const int kDefaultRtxH264PlType;
140 140
141 extern const int kDefaultVideoMaxWidth; 141 extern const int kDefaultVideoMaxWidth;
142 extern const int kDefaultVideoMaxHeight; 142 extern const int kDefaultVideoMaxHeight;
143 extern const int kDefaultVideoMaxFramerate; 143 extern const int kDefaultVideoMaxFramerate;
144 } // namespace cricket 144 } // namespace cricket
145 145
146 #endif // WEBRTC_MEDIA_BASE_MEDIACONSTANTS_H_ 146 #endif // WEBRTC_MEDIA_BASE_MEDIACONSTANTS_H_
OLDNEW
« no previous file with comments | « webrtc/api/webrtcsession_unittest.cc ('k') | webrtc/media/base/mediaconstants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698