Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2396823002: Use std::abs instead of C-style abs. (Closed)

Created:
4 years, 2 months ago by jianjunz
Modified:
4 years, 2 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use std::abs instead of C-style abs. BUG=webrtc:6486 Committed: https://crrev.com/a84aa57799fc4c7c832ba2e3614195b5231baa24 Cr-Commit-Position: refs/heads/master@{#14536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
jianjunz
PTAL.
4 years, 2 months ago (2016-10-05 15:18:36 UTC) #2
tkchin_webrtc
On 2016/10/05 15:18:36, jianjunz wrote: > PTAL. lgtm
4 years, 2 months ago (2016-10-05 20:58:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2396823002/1
4 years, 2 months ago (2016-10-05 22:05:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-06 00:06:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2396823002/1
4 years, 2 months ago (2016-10-06 02:03:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 02:19:26 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 02:19:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a84aa57799fc4c7c832ba2e3614195b5231baa24
Cr-Commit-Position: refs/heads/master@{#14536}

Powered by Google App Engine
This is Rietveld 408576698