Restore thread name consistency for webrtc/p2p/ .

webrtc/p2p/base/dtlstransportchannel.h

Index: webrtc/p2p/base/dtlstransportchannel.h
diff --git a/webrtc/p2p/base/dtlstransportchannel.h b/webrtc/p2p/base/dtlstransportchannel.h
index a07c605e051c82f3b162dd6ee32ff182788e3038..5666d356088ce1f4a6d440bf51eb92f29df2c292 100644
--- a/webrtc/p2p/base/dtlstransportchannel.h
+++ b/webrtc/p2p/base/dtlstransportchannel.h
@@ -224,7 +224,7 @@ class DtlsTransportChannelWrapper : public TransportChannelImpl {
   void OnChannelStateChanged(TransportChannelImpl* channel);
   void OnDtlsHandshakeError(rtc::SSLHandshakeError error);
 
-  rtc::Thread* worker_thread_;  // Everything should occur on this thread.
+  rtc::Thread* network_thread_;  // Everything should occur on this thread.

[danilchap, 2016/10/05 14:56:13]

this variable is used only to validate everything is run on this thread.
Might make sense to replace it with ThreadChecker (base/thread_checker):
rtc::ThreadChecker network_thread_checker_;
in .cc:
RTC_DCHECK_RUN_ON(&network_thread_checker_); instead of ASSERTs

[johan, 2016/10/05 16:13:24]

Basically I agree on preferring RTC_DCHECK family of macros over ASSERTs. As the
rtc::ThreadChecker at some point internally uses rtc::CritScope locks it is
possible to have impact on runtime behaviour for debug builds. It is still worth
a try, but I prefer to not mixing the move from ASSERTs to ThreadChecker into
this CL.

   // Underlying channel, not owned by this class.
   TransportChannelImpl* const channel_;
   std::unique_ptr<rtc::SSLStreamAdapter> dtls_;  // The DTLS stream