Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2396013002: Removing ERROR message for something that's expected to occur. (Closed)

Created:
4 years, 2 months ago by Taylor Brandstetter
Modified:
4 years, 2 months ago
Reviewers:
pthatcher2, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing ERROR message for something that's expected to occur. This error occurred if you created a data channel before there's a data m= section. But this is expected to happen, since creating a data channel is how you get a data m= section in the first place. BUG=chromium:579430 NOTRY=true TBR=pthatcher@webrtc.org Committed: https://crrev.com/daf88b1cbf878af0071cfd7942ea4c65322f87ba Cr-Commit-Position: refs/heads/master@{#14537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M webrtc/api/webrtcsession.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Taylor Brandstetter
4 years, 2 months ago (2016-10-06 05:21:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2396013002/1
4 years, 2 months ago (2016-10-06 05:24:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 05:29:33 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/daf88b1cbf878af0071cfd7942ea4c65322f87ba Cr-Commit-Position: refs/heads/master@{#14537}
4 years, 2 months ago (2016-10-06 05:29:43 UTC) #9
pthatcher2
4 years, 2 months ago (2016-10-06 16:44:26 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698