Remove deprecated FSRef-manipulation methods.

Remove deprecated FSRef-manipulation methods.

The replacement methods had already been added to applefilesystem.mm, they just
weren't being used on macOS.

BUG=webrtc:6028
Committed: https://crrev.com/2ca8d5c4308699918efe940cfb5d1e0e1fbe112e
Cr-Commit-Position: refs/heads/master@{#14535}

[erikchen, 2016-10-04 20:02:11]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 20:02:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-04 20:02:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 20:02:14]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

[erikchen, 2016-10-04 20:03:59]

erikchen@chromium.org changed reviewers:
+ henrika@webrtc.org

[erikchen, 2016-10-04 20:03:59]

henrika: Please review.

I tested this by enabling the Firefox profile tests in ProxyDetectTest and
printing the app folder before/after the change and making sure that they were
the same.

[erikchen, 2016-10-04 20:41:42]

Description was changed from

==========
Remove deprecated FSRef-manipulation methods.

The replacement methods had already been added to applefilesystem.mm, they just
weren't being used on macOS.

BUG=6028
==========

to

==========
Remove deprecated FSRef-manipulation methods.

The replacement methods had already been added to applefilesystem.mm, they just
weren't being used on macOS.

BUG=webrtc:6028
==========

[henrika (OOO until Aug 14), 2016-10-05 08:39:49]

henrika@chromium.org changed reviewers:
+ kthelgason@webrtc.org, magjed@webrtc.org
- henrika@webrtc.org

[henrika (OOO until Aug 14), 2016-10-05 08:41:07]

henrika@chromium.org changed reviewers:
+ henrika@chromium.org

[henrika (OOO until Aug 14), 2016-10-05 08:41:08]

Changing owners since I have not done any work in webrtc/base.

[kjellander_webrtc, 2016-10-05 11:31:30]

On 2016/10/05 08:41:08, henrika wrote:
> Changing owners since I have not done any work in webrtc/base.

Please use the https://codereview.webrtc.org/2395593002/ URL for this CL. We
share the same code review instance as Chromium but use
https://codereview.webrtc.org/ in order to be able to use different e-mail
addresses for WebRTC vs Chromium reviews.

[kthelgason, 2016-10-05 11:34:43]

lgtm, thanks.

[magjed_webrtc, 2016-10-05 13:08:15]

lgtm

https://codereview.webrtc.org/2395593002/diff/1/webrtc/base/proxydetect.cc
File webrtc/base/proxydetect.cc (right):

https://codereview.webrtc.org/2395593002/diff/1/webrtc/base/proxydetect.cc#ne...
webrtc/base/proxydetect.cc:399: if (!result)
nit: just 'return result;' here.

[erikchen, 2016-10-05 16:53:59]

https://codereview.webrtc.org/2395593002/diff/1/webrtc/base/proxydetect.cc
File webrtc/base/proxydetect.cc (right):

https://codereview.webrtc.org/2395593002/diff/1/webrtc/base/proxydetect.cc#ne...
webrtc/base/proxydetect.cc:399: if (!result)
On 2016/10/05 13:08:15, magjed_webrtc wrote:
> nit: just 'return result;' here.

Done.

[erikchen, 2016-10-05 16:54:02]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-10-05 16:54:02]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
kthelgason@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2395593002/#ps20001 (title:
"comments from magjed")

[commit-bot: I haz the power, 2016-10-05 16:54:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-05 17:04:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 17:04:20]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8995)

[erikchen, 2016-10-05 17:10:16]

erikchen@chromium.org changed reviewers:
+ sergeyu@chromium.org

[erikchen, 2016-10-05 17:10:17]

+sergeyu for OWNER review.

[Sergey Ulanov, 2016-10-05 22:55:30]

lgtm

[erikchen, 2016-10-05 22:56:00]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-10-05 22:56:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-05 23:04:36]

Description was changed from

==========
Remove deprecated FSRef-manipulation methods.

The replacement methods had already been added to applefilesystem.mm, they just
weren't being used on macOS.

BUG=webrtc:6028
==========

to

==========
Remove deprecated FSRef-manipulation methods.

The replacement methods had already been added to applefilesystem.mm, they just
weren't being used on macOS.

BUG=webrtc:6028
==========

[commit-bot: I haz the power, 2016-10-05 23:04:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 23:04:44]

Description was changed from

==========
Remove deprecated FSRef-manipulation methods.

The replacement methods had already been added to applefilesystem.mm, they just
weren't being used on macOS.

BUG=webrtc:6028
==========

to

==========
Remove deprecated FSRef-manipulation methods.

The replacement methods had already been added to applefilesystem.mm, they just
weren't being used on macOS.

BUG=webrtc:6028

Committed: https://crrev.com/2ca8d5c4308699918efe940cfb5d1e0e1fbe112e
Cr-Commit-Position: refs/heads/master@{#14535}
==========

[commit-bot: I haz the power, 2016-10-05 23:04:45]

Patchset 2 (id:??) landed as
https://crrev.com/2ca8d5c4308699918efe940cfb5d1e0e1fbe112e
Cr-Commit-Position: refs/heads/master@{#14535}