Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2395433003: Add camera start/stop time stats to VideoCapturerAndroid. (Closed)

Created:
4 years, 2 months ago by sakal
Modified:
4 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add camera start/stop time stats to VideoCapturerAndroid. BUG=webrtc:6302 Committed: https://crrev.com/55b9544290749cf979366a2ef773114771feed24 Cr-Commit-Position: refs/heads/master@{#14548}

Patch Set 1 : Add start event to byte buffer capturing. #

Total comments: 2

Patch Set 2 : Change startStartTimeMs -> startStartTimeNs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java View 1 9 chunks +27 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sakal
PTAL
4 years, 2 months ago (2016-10-04 15:12:56 UTC) #5
magjed_webrtc
https://codereview.chromium.org/2395433003/diff/40001/webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java File webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java (right): https://codereview.chromium.org/2395433003/diff/40001/webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java#newcode91 webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java:91: private long startStartTimeMs; // The time in nanoseconds when ...
4 years, 2 months ago (2016-10-05 08:42:58 UTC) #6
sakal
https://codereview.webrtc.org/2395433003/diff/40001/webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java File webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java (right): https://codereview.webrtc.org/2395433003/diff/40001/webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java#newcode91 webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java:91: private long startStartTimeMs; // The time in nanoseconds when ...
4 years, 2 months ago (2016-10-06 07:38:25 UTC) #7
magjed_webrtc
lgtm
4 years, 2 months ago (2016-10-06 09:11:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2395433003/60001
4 years, 2 months ago (2016-10-06 09:21:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 2 months ago (2016-10-06 09:59:45 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 09:59:57 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55b9544290749cf979366a2ef773114771feed24
Cr-Commit-Position: refs/heads/master@{#14548}

Powered by Google App Engine
This is Rietveld 408576698