Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2395383002: Replace rtcp parser in rtc event log handlers. (Closed)

Created:
4 years, 2 months ago by danilchap
Modified:
4 years, 2 months ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Taylor Brandstetter
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace rtcp parser in rtc event log handlers. RTCPUtility is going away. BUG=webrtc:5260 Committed: https://crrev.com/bf369fe3dd65f8d43775e181832add5a92488551 Cr-Commit-Position: refs/heads/master@{#14574}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -46 lines) Patch
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 2 chunks +24 lines, -23 lines 2 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 2 chunks +15 lines, -23 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
danilchap
4 years, 2 months ago (2016-10-07 09:08:08 UTC) #2
terelius
lgtm with one question: https://codereview.webrtc.org/2395383002/diff/1/webrtc/logging/rtc_event_log/rtc_event_log.cc File webrtc/logging/rtc_event_log/rtc_event_log.cc (right): https://codereview.webrtc.org/2395383002/diff/1/webrtc/logging/rtc_event_log/rtc_event_log.cc#newcode354 webrtc/logging/rtc_event_log/rtc_event_log.cc:354: case rtcp::ExtendedReports::kPacketType: There is no ...
4 years, 2 months ago (2016-10-07 12:39:25 UTC) #3
danilchap
https://codereview.webrtc.org/2395383002/diff/1/webrtc/logging/rtc_event_log/rtc_event_log.cc File webrtc/logging/rtc_event_log/rtc_event_log.cc (right): https://codereview.webrtc.org/2395383002/diff/1/webrtc/logging/rtc_event_log/rtc_event_log.cc#newcode354 webrtc/logging/rtc_event_log/rtc_event_log.cc:354: case rtcp::ExtendedReports::kPacketType: On 2016/10/07 12:39:25, terelius wrote: > There ...
4 years, 2 months ago (2016-10-07 12:45:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2395383002/1
4 years, 2 months ago (2016-10-07 14:09:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 14:39:56 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 14:40:07 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf369fe3dd65f8d43775e181832add5a92488551
Cr-Commit-Position: refs/heads/master@{#14574}

Powered by Google App Engine
This is Rietveld 408576698