Prune connections based on network name.

Prune connections based on network name.
Previously we prune connections on the same network pointer.
So if an IPv6 and an IPv4 network are on the same network interface, IPv4 connection won't be pruned even if an IPv6 connection with higher priority becomes writable.

With this change, as long as one connection becomes writable, all connections  having lower priority with the same network name will be pruned.

Also simplify the implementation.

BUG=webrtc:6512
Committed: https://crrev.com/aae2784c1fab9d1510393dec15d76caa574e2da8
Cr-Commit-Position: refs/heads/master@{#14593}

[honghaiz3, 2016-10-08 00:37:32]

Description was changed from

==========
Prune connections based on network name.
Also simply the implementation.

BUG=
==========

to

==========
Prune connections based on network name.
Previously we prune connections on the same network pointer. 
So if an IPv6 and an IPv4 network on the same network interface, IPv4 connection
won't pruned even if an IPv6 connection with higher priority becomes writable. 

With this change, as long as one connection becomes writable, all connections 
having lower priority with the same network name will be pruned. 

Also simplify the implementation.

BUG=
==========

[honghaiz3, 2016-10-08 00:47:52]

Patchset #1 (id:1) has been deleted

[honghaiz3, 2016-10-08 00:47:57]

Patchset #1 (id:20001) has been deleted

[honghaiz3, 2016-10-08 00:48:02]

Patchset #1 (id:40001) has been deleted

[skvlad, 2016-10-10 18:23:03]

skvlad@webrtc.org changed reviewers:
+ skvlad@webrtc.org

[skvlad, 2016-10-10 18:23:04]

lgtm

https://codereview.webrtc.org/2395243005/diff/50005/webrtc/p2p/base/fakeporta...
File webrtc/p2p/base/fakeportallocator.h (right):

https://codereview.webrtc.org/2395243005/diff/50005/webrtc/p2p/base/fakeporta...
webrtc/p2p/base/fakeportallocator.h:129:
&FakePortAllocatorSession::OnPortDestroyed);
Very minor: can this me moved to inside AddPort?

[honghaiz3, 2016-10-10 19:31:30]

The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 19:31:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[honghaiz3, 2016-10-10 19:35:28]

Thanks!

https://codereview.webrtc.org/2395243005/diff/50005/webrtc/p2p/base/fakeporta...
File webrtc/p2p/base/fakeportallocator.h (right):

https://codereview.webrtc.org/2395243005/diff/50005/webrtc/p2p/base/fakeporta...
webrtc/p2p/base/fakeportallocator.h:129:
&FakePortAllocatorSession::OnPortDestroyed);
On 2016/10/10 18:23:04, skvlad wrote:
> Very minor: can this me moved to inside AddPort?

Done.

[honghaiz3, 2016-10-10 19:36:06]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-10-10 19:36:06]

The patchset sent to the CQ was uploaded after l-g-t-m from skvlad@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2395243005/#ps70001 (title:
"Address skvlad's comment")

[honghaiz3, 2016-10-10 19:36:10]

The CQ bit was unchecked by honghaiz@webrtc.org

[commit-bot: I haz the power, 2016-10-10 19:36:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[honghaiz3, 2016-10-10 19:37:01]

Description was changed from

==========
Prune connections based on network name.
Previously we prune connections on the same network pointer. 
So if an IPv6 and an IPv4 network on the same network interface, IPv4 connection
won't pruned even if an IPv6 connection with higher priority becomes writable. 

With this change, as long as one connection becomes writable, all connections 
having lower priority with the same network name will be pruned. 

Also simplify the implementation.

BUG=
==========

to

==========
Prune connections based on network name.
Previously we prune connections on the same network pointer. 
So if an IPv6 and an IPv4 network are on the same network interface, IPv4
connection won't be pruned even if an IPv6 connection with higher priority
becomes writable. 

With this change, as long as one connection becomes writable, all connections 
having lower priority with the same network name will be pruned. 

Also simplify the implementation.

BUG=
==========

[honghaiz3, 2016-10-10 19:41:39]

Description was changed from

==========
Prune connections based on network name.
Previously we prune connections on the same network pointer. 
So if an IPv6 and an IPv4 network are on the same network interface, IPv4
connection won't be pruned even if an IPv6 connection with higher priority
becomes writable. 

With this change, as long as one connection becomes writable, all connections 
having lower priority with the same network name will be pruned. 

Also simplify the implementation.

BUG=
==========

to

==========
Prune connections based on network name.
Previously we prune connections on the same network pointer. 
So if an IPv6 and an IPv4 network are on the same network interface, IPv4
connection won't be pruned even if an IPv6 connection with higher priority
becomes writable. 

With this change, as long as one connection becomes writable, all connections 
having lower priority with the same network name will be pruned. 

Also simplify the implementation.

BUG=webrtc:6512
==========

[honghaiz3, 2016-10-10 19:41:54]

The CQ bit was checked by honghaiz@webrtc.org

[commit-bot: I haz the power, 2016-10-10 19:42:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-10 20:08:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 20:08:16]

Try jobs failed on following builders:
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)

[honghaiz3, 2016-10-10 20:53:07]

The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 20:53:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-10 21:05:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 21:05:50]

Dry run: Try jobs failed on following builders:
  linux_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/19083)

[honghaiz3, 2016-10-10 21:29:03]

Patchset #3 (id:90001) has been deleted

[honghaiz3, 2016-10-10 21:29:15]

The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 21:29:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-10 22:00:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 22:00:20]

Dry run: This issue passed the CQ dry run.

[honghaiz3, 2016-10-10 22:09:32]

Patchset #3 (id:110001) has been deleted

[honghaiz3, 2016-10-10 22:10:06]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-10-10 22:10:07]

The patchset sent to the CQ was uploaded after l-g-t-m from skvlad@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2395243005/#ps130001 (title:
"Override system-provided HasIPv6Enabled method")

[commit-bot: I haz the power, 2016-10-10 22:10:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-10 23:00:43]

Description was changed from

==========
Prune connections based on network name.
Previously we prune connections on the same network pointer. 
So if an IPv6 and an IPv4 network are on the same network interface, IPv4
connection won't be pruned even if an IPv6 connection with higher priority
becomes writable. 

With this change, as long as one connection becomes writable, all connections 
having lower priority with the same network name will be pruned. 

Also simplify the implementation.

BUG=webrtc:6512
==========

to

==========
Prune connections based on network name.
Previously we prune connections on the same network pointer. 
So if an IPv6 and an IPv4 network are on the same network interface, IPv4
connection won't be pruned even if an IPv6 connection with higher priority
becomes writable. 

With this change, as long as one connection becomes writable, all connections 
having lower priority with the same network name will be pruned. 

Also simplify the implementation.

BUG=webrtc:6512
==========

[commit-bot: I haz the power, 2016-10-10 23:00:45]

Committed patchset #3 (id:130001)

[commit-bot: I haz the power, 2016-10-10 23:00:52]

Description was changed from

==========
Prune connections based on network name.
Previously we prune connections on the same network pointer. 
So if an IPv6 and an IPv4 network are on the same network interface, IPv4
connection won't be pruned even if an IPv6 connection with higher priority
becomes writable. 

With this change, as long as one connection becomes writable, all connections 
having lower priority with the same network name will be pruned. 

Also simplify the implementation.

BUG=webrtc:6512
==========

to

==========
Prune connections based on network name.
Previously we prune connections on the same network pointer.
So if an IPv6 and an IPv4 network are on the same network interface, IPv4
connection won't be pruned even if an IPv6 connection with higher priority
becomes writable.

With this change, as long as one connection becomes writable, all connections 
having lower priority with the same network name will be pruned.

Also simplify the implementation.

BUG=webrtc:6512

Committed: https://crrev.com/aae2784c1fab9d1510393dec15d76caa574e2da8
Cr-Commit-Position: refs/heads/master@{#14593}
==========

[commit-bot: I haz the power, 2016-10-10 23:00:52]

Patchset 3 (id:??) landed as
https://crrev.com/aae2784c1fab9d1510393dec15d76caa574e2da8
Cr-Commit-Position: refs/heads/master@{#14593}

[sprang_webrtc, 2016-10-11 13:43:07]

A revert of this CL (patchset #3 id:130001) has been created in
https://codereview.webrtc.org/2412433003/ by sprang@webrtc.org.

The reason for reverting is: Breaks upstream code..