Skip non-continuous FrameInfos when finding the next frame to return from FrameBuffer::NextFrame.

Skip non-continuous FrameInfos when finding the next frame to return from FrameBuffer::NextFrame.

Also added DCHECKS to make sure that FrameInfos are not incorrectly updated.

BUG=webrtc:5514
R=stefan@webrtc.org

Committed: https://crrev.com/93e451b0f5b09784c29d90407078c5e6ab771d94
Cr-Commit-Position: refs/heads/master@{#14549}

[philipel, 2016-10-05 11:23:32]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-10-05 14:02:49]

lgtm

https://codereview.webrtc.org/2394823002/diff/1/webrtc/modules/video_coding/f...
File webrtc/modules/video_coding/frame_buffer2.cc (right):

https://codereview.webrtc.org/2394823002/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/frame_buffer2.cc:253: RTC_DCHECK(ref_info !=
frames_.end());
NE?

[philipel, 2016-10-05 14:29:51]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2016-10-05 14:30:01]

https://codereview.webrtc.org/2394823002/diff/1/webrtc/modules/video_coding/f...
File webrtc/modules/video_coding/frame_buffer2.cc (right):

https://codereview.webrtc.org/2394823002/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/frame_buffer2.cc:253: RTC_DCHECK(ref_info !=
frames_.end());
On 2016/10/05 14:02:49, stefan-webrtc (holmer) wrote:
> NE?

Sorry, comparing iterators don't work with the DCHECK macros.

[commit-bot: I haz the power, 2016-10-05 14:30:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-05 14:43:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 14:43:51]

Try jobs failed on following builders:
  win_x64_clang_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_dbg/build...)

[philipel, 2016-10-06 10:25:29]

Description was changed from

==========
Skip non-continuous FrameInfos when finding the next frame to return from
FrameBuffer::NextFrame.

Also added DCHECKS to make sure that FrameInfos are not incorrectly updated.

BUG=webrtc:5514
==========

to

==========
Skip non-continuous FrameInfos when finding the next frame to return from
FrameBuffer::NextFrame.

Also added DCHECKS to make sure that FrameInfos are not incorrectly updated.

BUG=webrtc:5514
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/93e451b0f5b09784c29d90407...
==========

[philipel, 2016-10-06 10:25:30]

Committed patchset #1 (id:1) manually as
93e451b0f5b09784c29d90407078c5e6ab771d94 (presubmit successful).

[commit-bot: I haz the power, 2016-10-06 10:25:31]

Description was changed from

==========
Skip non-continuous FrameInfos when finding the next frame to return from
FrameBuffer::NextFrame.

Also added DCHECKS to make sure that FrameInfos are not incorrectly updated.

BUG=webrtc:5514
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/93e451b0f5b09784c29d90407...
==========

to

==========
Skip non-continuous FrameInfos when finding the next frame to return from
FrameBuffer::NextFrame.

Also added DCHECKS to make sure that FrameInfos are not incorrectly updated.

BUG=webrtc:5514
R=stefan@webrtc.org

Committed: https://crrev.com/93e451b0f5b09784c29d90407078c5e6ab771d94
Cr-Commit-Position: refs/heads/master@{#14549}
==========