Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2393653002: Disable flaky Android capture tests: (Closed)

Created:
4 years, 2 months ago by skvlad
Modified:
4 years, 2 months ago
Reviewers:
AlexG, magjed_webrtc, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable flaky Android capture tests: - org.appspot.apprtc.test.PeerConnectionClientTest#testCaptureFormatChange - org.appspot.apprtc.test.PeerConnectionClientTest#testVideoSourceRestart BUG=webrtc:6478 R=glaznev@webrtc.org, sakal@webrtc.org Committed: https://crrev.com/134af7a9af34ab0b3c73874edce0b72e9a519a5a Cr-Commit-Position: refs/heads/master@{#14533}

Patch Set 1 #

Patch Set 2 : Disabled tests as per the Chromium instructions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java View 1 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
skvlad
4 years, 2 months ago (2016-10-04 19:14:09 UTC) #2
sakal
lgtm We should investigate why the tests have started failing though.
4 years, 2 months ago (2016-10-05 13:30:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2393653002/20001
4 years, 2 months ago (2016-10-05 18:10:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9000)
4 years, 2 months ago (2016-10-05 18:38:20 UTC) #9
AlexG
lgtm
4 years, 2 months ago (2016-10-05 22:02:41 UTC) #10
skvlad
Committed patchset #2 (id:20001) manually as 134af7a9af34ab0b3c73874edce0b72e9a519a5a (presubmit successful).
4 years, 2 months ago (2016-10-05 22:05:32 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 22:05:33 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/134af7a9af34ab0b3c73874edce0b72e9a519a5a
Cr-Commit-Position: refs/heads/master@{#14533}

Powered by Google App Engine
This is Rietveld 408576698