Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 2393143002: Speculatively increase timeouts for DirectRTCClientTest to reduce flakiness. (Closed)

Created:
4 years, 2 months ago by sakal
Modified:
4 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Speculatively increase timeouts for DirectRTCClientTest to reduce flakiness. BUG=webrtc:6475 Committed: https://crrev.com/11d37ba862319b5bb656489fc86749a10da4ed8d Cr-Commit-Position: refs/heads/master@{#14539}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sakal
PTAL
4 years, 2 months ago (2016-10-05 09:06:16 UTC) #3
magjed_webrtc
lgtm, but if the tests are still flaky after this, we need to redesign the ...
4 years, 2 months ago (2016-10-05 11:06:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2393143002/1
4 years, 2 months ago (2016-10-05 12:02:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-05 14:02:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2393143002/1
4 years, 2 months ago (2016-10-06 07:33:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 07:34:43 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 07:34:52 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11d37ba862319b5bb656489fc86749a10da4ed8d
Cr-Commit-Position: refs/heads/master@{#14539}

Powered by Google App Engine
This is Rietveld 408576698