Fixed flaky clock_unittest by using relative comparison.

Fixed flaky clock_unittest by using relative comparison.

ClockTest.NtpTime was checking that the two methods for getting the
system time are returning a value that is within a fixed error margin
(100 ms) of each other. Unfortunately, even such a wide margin was
sometimes exceeded on heavily loaded machines
(https://build.chromium.org/p/client.webrtc/builders/Mac%20Asan/builds/9235/steps/system_wrappers_unittests/logs/stdio).

This CL changes the test to sandwich clock->CurrentNtp() between
clock->CurrentNtpTimeInMilliseconds(). This way the test will pass no
matter how much time elapses between the two method calls, as long as
the clock is monotonic.

Repeated test runs showed that there may be 1 ms worth of rounding error
between the two methods of getting time, so we have to allow that.

BUG=None.

Committed: https://crrev.com/de3f844a2099eaae32e61c87b509750c94215f59
Cr-Commit-Position: refs/heads/master@{#14520}

[skvlad, 2016-10-04 23:36:09]

skvlad@webrtc.org changed reviewers:
+ henrika@webrtc.org, mflodman@webrtc.org, perkj@webrtc.org

[skvlad, 2016-10-04 23:36:09]

PTAL. This is a fix for a flaky test:
https://build.chromium.org/p/client.webrtc/builders/Mac%20Asan/builds/9235/st...

[henrika_webrtc, 2016-10-05 08:22:19]

LGTM

[skvlad, 2016-10-05 08:53:32]

The CQ bit was checked by skvlad@webrtc.org

[commit-bot: I haz the power, 2016-10-05 08:53:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-05 08:55:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-05 08:55:15]

Description was changed from

==========
Fixed flaky clock_unittest by using relative comparison.

ClockTest.NtpTime was checking that the two methods for getting the
system time are returning a value that is within a fixed error margin
(100 ms) of each other. Unfortunately, even such a wide margin was
sometimes exceeded on heavily loaded machines
(https://build.chromium.org/p/client.webrtc/builders/Mac%20Asan/builds/9235/st...).

This CL changes the test to sandwich clock->CurrentNtp() between
clock->CurrentNtpTimeInMilliseconds(). This way the test will pass no
matter how much time elapses between the two method calls, as long as
the clock is monotonic.

Repeated test runs showed that there may be 1 ms worth of rounding error
between the two methods of getting time, so we have to allow that.

BUG=None.
==========

to

==========
Fixed flaky clock_unittest by using relative comparison.

ClockTest.NtpTime was checking that the two methods for getting the
system time are returning a value that is within a fixed error margin
(100 ms) of each other. Unfortunately, even such a wide margin was
sometimes exceeded on heavily loaded machines
(https://build.chromium.org/p/client.webrtc/builders/Mac%20Asan/builds/9235/st...).

This CL changes the test to sandwich clock->CurrentNtp() between
clock->CurrentNtpTimeInMilliseconds(). This way the test will pass no
matter how much time elapses between the two method calls, as long as
the clock is monotonic.

Repeated test runs showed that there may be 1 ms worth of rounding error
between the two methods of getting time, so we have to allow that.

BUG=None.

Committed: https://crrev.com/de3f844a2099eaae32e61c87b509750c94215f59
Cr-Commit-Position: refs/heads/master@{#14520}
==========

[commit-bot: I haz the power, 2016-10-05 08:55:17]

Patchset 1 (id:??) landed as
https://crrev.com/de3f844a2099eaae32e61c87b509750c94215f59
Cr-Commit-Position: refs/heads/master@{#14520}