Fixed flaky SharedExclusiveLock tests.

Fixed flaky SharedExclusiveLock tests.

These tests were checking the behavior of thread synchronization
primitives using nothing but carefully timed sleeps. This was very
unreliable and prone to flakes.

This CL replaces the sleeps with waiting on synchronization events.
There is still the need to wait for timeouts when testing for negative
outcomes, but it's greatly reduced. I've run these tests for thousands
of iterations on MSan without a single failure.

BUG=webrtc:5824
R=pthatcher@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/efc5ae94f96606d4f876928b2b56ac91d794f9c5

[skvlad, 2016-10-04 21:15:58]

Description was changed from

==========
Fixed flaky SharedExclusiveLock tests.

These tests were checking the behavior of thread synchronization
primitives using nothing but carefully timed sleeps. This was very
unreliable and prone to flakes.

This CL replaces the sleeps with waiting on synchronization events.
There is still the need to wait for timeouts when testing for negative
outcomes, but it's greatly reduced. I've run these tests for thousands
of iterations on MSan without a single failure.

BUG=5824
==========

to

==========
Fixed flaky SharedExclusiveLock tests.

These tests were checking the behavior of thread synchronization
primitives using nothing but carefully timed sleeps. This was very
unreliable and prone to flakes.

This CL replaces the sleeps with waiting on synchronization events.
There is still the need to wait for timeouts when testing for negative
outcomes, but it's greatly reduced. I've run these tests for thousands
of iterations on MSan without a single failure.

BUG=webrtc:5824
==========

[pthatcher1, 2016-10-05 21:08:38]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2016-10-05 21:08:38]

lgtm

[skvlad, 2016-10-05 21:34:00]

The CQ bit was checked by skvlad@webrtc.org

[commit-bot: I haz the power, 2016-10-05 21:34:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-05 22:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 22:43:52]

Try jobs failed on following builders:
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/18436)

[skvlad, 2016-10-05 22:58:22]

Description was changed from

==========
Fixed flaky SharedExclusiveLock tests.

These tests were checking the behavior of thread synchronization
primitives using nothing but carefully timed sleeps. This was very
unreliable and prone to flakes.

This CL replaces the sleeps with waiting on synchronization events.
There is still the need to wait for timeouts when testing for negative
outcomes, but it's greatly reduced. I've run these tests for thousands
of iterations on MSan without a single failure.

BUG=webrtc:5824
==========

to

==========
Fixed flaky SharedExclusiveLock tests.

These tests were checking the behavior of thread synchronization
primitives using nothing but carefully timed sleeps. This was very
unreliable and prone to flakes.

This CL replaces the sleeps with waiting on synchronization events.
There is still the need to wait for timeouts when testing for negative
outcomes, but it's greatly reduced. I've run these tests for thousands
of iterations on MSan without a single failure.

BUG=webrtc:5824
R=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/efc5ae94f96606d4f876928b2...
==========

[commit-bot: I haz the power, 2016-10-05 22:58:22]

Description was changed from

==========
Fixed flaky SharedExclusiveLock tests.

These tests were checking the behavior of thread synchronization
primitives using nothing but carefully timed sleeps. This was very
unreliable and prone to flakes.

This CL replaces the sleeps with waiting on synchronization events.
There is still the need to wait for timeouts when testing for negative
outcomes, but it's greatly reduced. I've run these tests for thousands
of iterations on MSan without a single failure.

BUG=webrtc:5824
R=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/efc5ae94f96606d4f876928b2...
==========

to

==========
Fixed flaky SharedExclusiveLock tests.

These tests were checking the behavior of thread synchronization
primitives using nothing but carefully timed sleeps. This was very
unreliable and prone to flakes.

This CL replaces the sleeps with waiting on synchronization events.
There is still the need to wait for timeouts when testing for negative
outcomes, but it's greatly reduced. I've run these tests for thousands
of iterations on MSan without a single failure.

BUG=webrtc:5824
R=pthatcher@webrtc.org

Committed: https://crrev.com/efc5ae94f96606d4f876928b2b56ac91d794f9c5
Cr-Commit-Position: refs/heads/master@{#14534}
==========

[skvlad, 2016-10-05 22:58:23]

Committed patchset #2 (id:20001) manually as
efc5ae94f96606d4f876928b2b56ac91d794f9c5 (presubmit successful).