Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 2392913002: Delete httpportallocator.h. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete httpportallocator.h. BUG=webrtc:6424 Committed: https://crrev.com/3d7901d1bdd8e3c594da563001ee1309c72f4f82 Cr-Commit-Position: refs/heads/master@{#14516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -368 lines) Patch
M webrtc/p2p/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/p2p/client/basicportallocator_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/p2p/client/httpportallocator.h View 1 chunk +0 lines, -141 lines 0 comments Download
D webrtc/p2p/client/httpportallocator.cc View 1 chunk +0 lines, -222 lines 0 comments Download
M webrtc/p2p/p2p.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nisse-webrtc
Appear unused, as soon as https://codereview.chromium.org/2393533002/ is landed.
4 years, 2 months ago (2016-10-04 13:45:55 UTC) #2
pthatcher1
lgtm
4 years, 2 months ago (2016-10-04 15:44:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2392913002/1
4 years, 2 months ago (2016-10-05 06:20:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 07:46:44 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 07:46:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d7901d1bdd8e3c594da563001ee1309c72f4f82
Cr-Commit-Position: refs/heads/master@{#14516}

Powered by Google App Engine
This is Rietveld 408576698