Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: webrtc/modules/rtp_rtcp/include/flexfec_receiver.h

Issue 2392663006: Add a FlexfecReceiver class. (Closed)
Patch Set: Add a FlexfecReceiver class. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/include/flexfec_receiver.h
diff --git a/webrtc/modules/rtp_rtcp/include/flexfec_receiver.h b/webrtc/modules/rtp_rtcp/include/flexfec_receiver.h
new file mode 100644
index 0000000000000000000000000000000000000000..5ffd3f958fff4e15f7f8a246de801af3172e6588
--- /dev/null
+++ b/webrtc/modules/rtp_rtcp/include/flexfec_receiver.h
@@ -0,0 +1,52 @@
+/*
+ * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_MODULES_RTP_RTCP_INCLUDE_FLEXFEC_RECEIVER_H_
+#define WEBRTC_MODULES_RTP_RTCP_INCLUDE_FLEXFEC_RECEIVER_H_
+
+#include <memory>
+
+#include "webrtc/base/basictypes.h"
+#include "webrtc/modules/rtp_rtcp/include/fec_receiver.h"
+
+namespace webrtc {
+
+// Callback interface for packets recovered by FlexFEC.
brandtr 2016/10/05 13:15:54 This interface is a subset of the RtpData interfac
stefan-webrtc 2016/10/05 14:45:59 Fine with me to have a new interface.
brandtr 2016/10/06 08:38:57 Acknowledged.
+class RecoveredPacketReceiver {
+ public:
+ virtual ~RecoveredPacketReceiver();
danilchap 2016/10/05 14:32:04 if you do no plan to delete RecoveredPacketReceive
brandtr 2016/10/06 08:38:57 Good idea, done!
+
+ virtual bool OnRecoveredPacket(const uint8_t* packet, size_t length) = 0;
+};
+
+class FlexfecReceiver {
+ public:
+ static std::unique_ptr<FlexfecReceiver> Create(
+ uint32_t flexfec_ssrc,
+ uint32_t protected_media_ssrc,
+ RecoveredPacketReceiver* callback);
+ virtual ~FlexfecReceiver();
+
+ // Inserts a received packet (can be either media or FlexFEC) into the
+ // internal buffer.
+ virtual bool AddReceivedPacket(const uint8_t* packet,
+ size_t packet_length) = 0;
+
+ // Sends the received packets to the erasure code and returns all
+ // recovered media packets through the callback.
+ virtual bool ProcessReceivedPackets() = 0;
stefan-webrtc 2016/10/05 14:45:59 Is it worth having this method, or should we simpl
brandtr 2016/10/06 08:38:57 Currently, we always process whenever we receive a
+
+ // Returns a counter describing the added and recovered packets.
+ virtual FecPacketCounter GetPacketCounter() const = 0;
+};
+
+} // namespace webrtc
+
+#endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_FLEXFEC_RECEIVER_H_

Powered by Google App Engine
This is Rietveld 408576698