Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc

Issue 2392313002: Drop VP8 frames older than the last sync frame in the RtpFrameReferenceFinder. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
diff --git a/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc b/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
index 1efd1c35b9e458f7f09923902c2921bdee705f2d..3c73601aadc30eaad6bb0acfaf7ec638c49ee994 100644
--- a/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
+++ b/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
@@ -597,6 +597,18 @@ TEST_F(TestRtpFrameReferenceFinder, Vp8LayerSync) {
CheckReferencesVp8(pid + 7, pid + 6, pid + 5);
}
+TEST_F(TestRtpFrameReferenceFinder, Vp8Tl1SyncFrameAfterTl1Frame) {
+ InsertVp8(1000, 1000, true, 1, 0, 247, true);
+ InsertVp8(1001, 1001, false, 3, 0, 248, false);
+ InsertVp8(1002, 1002, false, 4, 1, 248, false); // Will be dropped
+ InsertVp8(1003, 1003, false, 5, 1, 248, true); // due to this frame.
+
+ ASSERT_EQ(3UL, frames_from_callback_.size());
+ CheckReferencesVp8(1);
+ CheckReferencesVp8(3, 1);
+ CheckReferencesVp8(5, 3);
+}
+
TEST_F(TestRtpFrameReferenceFinder, Vp9GofInsertOneFrame) {
uint16_t pid = Rand();
uint16_t sn = Rand();

Powered by Google App Engine
This is Rietveld 408576698