Drop VP8 frames older than the last sync frame in the RtpFrameReferenceFinder.

Drop VP8 frames older than the last sync frame in the RtpFrameReferenceFinder.

BUG=webrtc:5514
Committed: https://crrev.com/86b92e05f9b64a98fdf1702ee2acec9ec6b1e95d
Cr-Commit-Position: refs/heads/master@{#14745}

[philipel, 2016-10-05 10:44:54]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-10-05 14:05:58]

lg, but one question

https://codereview.webrtc.org/2392313002/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtp_frame_reference_finder.cc (right):

https://codereview.webrtc.org/2392313002/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder.cc:303: // base layer
frame, drop this frame.
Is this always true though?

What if we received a stream with to layers where TL1 only depends on TL0? Maybe
because in that case all TL1 frames are sync frames, so it's still correct?

Anyway, if we have already decoded frame T, all frames prior to T are too late
to decode, right?

https://codereview.webrtc.org/2392313002/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder.cc:305:
frame->picture_id))
{}

[philipel, 2016-10-05 14:47:42]

https://codereview.webrtc.org/2392313002/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtp_frame_reference_finder.cc (right):

https://codereview.webrtc.org/2392313002/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder.cc:303: // base layer
frame, drop this frame.
On 2016/10/05 14:05:58, stefan-webrtc (holmer) wrote:
> Is this always true though?
> 
> What if we received a stream with to layers where TL1 only depends on TL0?
Maybe
> because in that case all TL1 frames are sync frames, so it's still correct?
> 
> Anyway, if we have already decoded frame T, all frames prior to T are too late
> to decode, right?

I can't find a case where this it not true, remember that every base layer frame
has its own LayerInfo.

Generally we should not make assumptions about which frame that has been decoded
or not since we pass the frame forward as soon as we have calculated all its
references, but in this case we know that dropping this frame is OK since we
know that we have passed on a more recent layer sync frame for this base layer
frame.

https://codereview.webrtc.org/2392313002/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder.cc:305:
frame->picture_id))
On 2016/10/05 14:05:58, stefan-webrtc (holmer) wrote:
> {}

Done.

[philipel, 2016-10-24 10:29:43]

ping

[philipel, 2016-10-24 10:30:23]

The CQ bit was checked by philipel@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 10:30:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[stefan-webrtc, 2016-10-24 10:38:00]

lgtm

[commit-bot: I haz the power, 2016-10-24 12:49:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 12:49:06]

Dry run: This issue passed the CQ dry run.

[philipel, 2016-10-24 14:09:54]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2016-10-24 14:10:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-24 14:11:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-24 14:12:09]

Description was changed from

==========
Drop VP8 frames older than the last sync frame in the RtpFrameReferenceFinder.

BUG=webrtc:5514
==========

to

==========
Drop VP8 frames older than the last sync frame in the RtpFrameReferenceFinder.

BUG=webrtc:5514

Committed: https://crrev.com/86b92e05f9b64a98fdf1702ee2acec9ec6b1e95d
Cr-Commit-Position: refs/heads/master@{#14745}
==========

[commit-bot: I haz the power, 2016-10-24 14:12:10]

Patchset 2 (id:??) landed as
https://crrev.com/86b92e05f9b64a98fdf1702ee2acec9ec6b1e95d
Cr-Commit-Position: refs/heads/master@{#14745}