Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2392053003: Make sure vp9 actually gets excluded in gn as well. (Closed)

Created:
4 years, 2 months ago by phoglund
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make sure vp9 actually gets excluded in gn as well. It was being excluded in this manner in gyp so it should be in gn as well. R=charujain@webrtc.org,kjellander@webrtc.org BUG=webrtc:6412 Committed: https://crrev.com/3360352c2bd7223642b3c1ee757d02e0f8d43cf0 Cr-Commit-Position: refs/heads/master@{#14525}

Patch Set 1 #

Patch Set 2 : Also set define #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M webrtc/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +15 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
phoglund
4 years, 2 months ago (2016-10-05 09:12:54 UTC) #1
charujain
lgtm
4 years, 2 months ago (2016-10-05 09:13:30 UTC) #2
kjellander_webrtc
lgtm, I added webrtc: to your BUG. You seem to need to update your git ...
4 years, 2 months ago (2016-10-05 09:25:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2392053003/20001
4 years, 2 months ago (2016-10-05 11:46:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 13:52:25 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 13:52:34 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3360352c2bd7223642b3c1ee757d02e0f8d43cf0
Cr-Commit-Position: refs/heads/master@{#14525}

Powered by Google App Engine
This is Rietveld 408576698