Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 2391263002: Add a fuzzer for FlexfecReceiver. (Closed)

Created:
4 years, 2 months ago by brandtr
Modified:
4 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
philipel, webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add a fuzzer for FlexfecReceiver. Specifically set max_len to 2000, to simulate multi-packet insertions. BUG=webrtc:5654 NOTRY=true Committed: https://crrev.com/e405d9b8df8705df70be8cdfef93398baf6b3c45 Cr-Commit-Position: refs/heads/master@{#14656}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Feedback response 1. #

Patch Set 3 : Update based on FlexfecReceiver interface changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -0 lines) Patch
M webrtc/test/fuzzers/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
A webrtc/test/fuzzers/flexfec_receiver_fuzzer.cc View 1 2 1 chunk +69 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (9 generated)
brandtr
4 years, 2 months ago (2016-10-05 13:16:44 UTC) #2
stefan-webrtc
https://codereview.webrtc.org/2391263002/diff/1/webrtc/test/fuzzers/flexfec_receiver_fuzzer.cc File webrtc/test/fuzzers/flexfec_receiver_fuzzer.cc (right): https://codereview.webrtc.org/2391263002/diff/1/webrtc/test/fuzzers/flexfec_receiver_fuzzer.cc#newcode27 webrtc/test/fuzzers/flexfec_receiver_fuzzer.cc:27: if (size < 12) { Make 12 a named ...
4 years, 2 months ago (2016-10-05 14:48:26 UTC) #3
brandtr
https://codereview.webrtc.org/2391263002/diff/1/webrtc/test/fuzzers/flexfec_receiver_fuzzer.cc File webrtc/test/fuzzers/flexfec_receiver_fuzzer.cc (right): https://codereview.webrtc.org/2391263002/diff/1/webrtc/test/fuzzers/flexfec_receiver_fuzzer.cc#newcode27 webrtc/test/fuzzers/flexfec_receiver_fuzzer.cc:27: if (size < 12) { On 2016/10/05 14:48:26, stefan-webrtc ...
4 years, 2 months ago (2016-10-05 15:00:39 UTC) #4
brandtr
Any more thoughts about this one?
4 years, 2 months ago (2016-10-16 20:35:42 UTC) #6
stefan-webrtc
lgtm
4 years, 2 months ago (2016-10-17 17:56:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2391263002/40001
4 years, 2 months ago (2016-10-17 17:57:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9235)
4 years, 2 months ago (2016-10-17 18:13:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2391263002/40001
4 years, 2 months ago (2016-10-18 06:50:05 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9244)
4 years, 2 months ago (2016-10-18 07:12:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2391263002/40001
4 years, 2 months ago (2016-10-18 08:16:52 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-18 08:18:08 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 08:18:17 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e405d9b8df8705df70be8cdfef93398baf6b3c45
Cr-Commit-Position: refs/heads/master@{#14656}

Powered by Google App Engine
This is Rietveld 408576698