Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: webrtc/sdk/objc/Framework/Classes/RTCVideoTrack.mm

Issue 2391123002: Add iOS static library GN build script. (Closed)
Patch Set: Update comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Classes/RTCVideoTrack.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/RTCVideoTrack.mm b/webrtc/sdk/objc/Framework/Classes/RTCVideoTrack.mm
index 6691375fbffb9ec601c598bd37448a69b7561627..9fa61114115a9f1a14d0b0e62f13c09145846c0a 100644
--- a/webrtc/sdk/objc/Framework/Classes/RTCVideoTrack.mm
+++ b/webrtc/sdk/objc/Framework/Classes/RTCVideoTrack.mm
@@ -69,9 +69,9 @@
- (void)addRenderer:(id<RTCVideoRenderer>)renderer {
// Make sure we don't have this renderer yet.
for (RTCVideoRendererAdapter *adapter in _adapters) {
- // Getting around unused variable error
- if (adapter.videoRenderer != renderer) {
+ if (adapter.videoRenderer == renderer) {
kthelgason 2016/10/05 07:46:24 This seems strange. Is this a bug that you're fixi
tkchin_webrtc 2016/10/05 16:42:26 See other comment.
NSAssert(NO, @"|renderer| is already attached to this track");
+ return;
}
}
// Create a wrapper that provides a native pointer for us.

Powered by Google App Engine
This is Rietveld 408576698