Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1556)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/modules/audio_coding/test/TestRedFec.cc

Issue 2390883004: Hooking up audio network adaptor to VoE. (Closed)
Patch Set: on Karl's comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc ('K') | « webrtc/modules/audio_coding/test/PacketLossTest.cc ('k') | webrtc/voice_engine/channel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_coding/test/TestRedFec.cc
diff --git a/webrtc/modules/audio_coding/test/TestRedFec.cc b/webrtc/modules/audio_coding/test/TestRedFec.cc
index dbb238f4998610e50579593b486334dc69713508..8161f34354b2b6cf778f6825adb8eb3df5de9d40 100644
--- a/webrtc/modules/audio_coding/test/TestRedFec.cc
+++ b/webrtc/modules/audio_coding/test/TestRedFec.cc
@@ -341,7 +341,10 @@ void TestRedFec::Perform() {
#endif
// _channelA2B imposes 25% packet loss rate.
- EXPECT_EQ(0, _acmA->SetPacketLossRate(25));
+ _acmA->ModifyEncoder([&](std::unique_ptr<AudioEncoder>* encoder) {
+ EXPECT_TRUE(*encoder);
+ (*encoder)->SetProjectedPacketLossRate(25.0 / 100.0);
kwiberg-webrtc 2016/10/11 10:18:42 Why is "25.0 / 100.0" better than just "0.25"?
minyue-webrtc 2016/10/11 10:38:35 sure. of course.
+ });
#ifdef SUPPORT_RED_FB
EXPECT_EQ(0, _acmA->SetREDStatus(true));
« webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc ('K') | « webrtc/modules/audio_coding/test/PacketLossTest.cc ('k') | webrtc/voice_engine/channel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698