Add path for recovered packets from internal::Call to RtpStreamReceiver.

Add path for recovered packets from internal::Call to RtpStreamReceiver.

When the FlexfecReceiver recovers media packets, it inserts these into
internal::Call, which then distributes them to the appropriate
VideoReceiveStream/RtpStreamReceiver.

BUG=webrtc:5654
Committed: https://crrev.com/9c4b4b47f4325b48e1856566a30983f9e4e30dd0
Cr-Commit-Position: refs/heads/master@{#14642}

[brandtr, 2016-10-07 08:07:58]

brandtr@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-10-10 15:42:02]

https://codereview.webrtc.org/2390823009/diff/1/webrtc/call/call.cc
File webrtc/call/call.cc (right):

https://codereview.webrtc.org/2390823009/diff/1/webrtc/call/call.cc#newcode963
webrtc/call/call.cc:963: if (it != video_receive_ssrcs_.end())
nit: I prefer the opposite, i.e., that errors are handled in the if statements
and the correct path ends the method.

if (it == ...end())
  return false;
return it->..OnRecoverdPacket(...);

Feel free to disagree though. :)

https://codereview.webrtc.org/2390823009/diff/1/webrtc/video/video_receive_st...
File webrtc/video/video_receive_stream.h (right):

https://codereview.webrtc.org/2390823009/diff/1/webrtc/video/video_receive_st...
webrtc/video/video_receive_stream.h:47: public RecoveredPacketReceiver {
It's not really necessary for this to implement RecoveredPacketReceiver. Maybe
we should not?

[brandtr, 2016-10-10 23:02:12]

Patchset #2 (id:20001) has been deleted

[brandtr, 2016-10-10 23:02:18]

Patchset #2 (id:40001) has been deleted

[brandtr, 2016-10-10 23:05:19]

https://codereview.webrtc.org/2390823009/diff/1/webrtc/call/call.cc
File webrtc/call/call.cc (right):

https://codereview.webrtc.org/2390823009/diff/1/webrtc/call/call.cc#newcode963
webrtc/call/call.cc:963: if (it != video_receive_ssrcs_.end())
On 2016/10/10 15:42:02, stefan-webrtc (holmer) wrote:
> nit: I prefer the opposite, i.e., that errors are handled in the if statements
> and the correct path ends the method.
> 
> if (it == ...end())
>   return false;
> return it->..OnRecoverdPacket(...);
> 
> Feel free to disagree though. :)

I think your suggestion makes it neater, so I've changed the code accordingly.

I modeled the original version of this function after DeliverRtp (see e.g.
https://cs.chromium.org/chromium/src/third_party/webrtc/call/call.cc?l=909), but
since that function tries multiple delivery paths before failing, I guess the
opposite order makes sense there.

https://codereview.webrtc.org/2390823009/diff/1/webrtc/video/video_receive_st...
File webrtc/video/video_receive_stream.h (right):

https://codereview.webrtc.org/2390823009/diff/1/webrtc/video/video_receive_st...
webrtc/video/video_receive_stream.h:47: public RecoveredPacketReceiver {
On 2016/10/10 15:42:02, stefan-webrtc (holmer) wrote:
> It's not really necessary for this to implement RecoveredPacketReceiver. Maybe
> we should not?

You are absolutely right. It doesn't really make sense for this class to
implement that interface, since my (previously undocumented) intention with the
interface is that the implementation demultiplexes the recovered packet based on
SSRC. And this class can't do that...

[stefan-webrtc, 2016-10-16 19:11:05]

lgtm

[brandtr, 2016-10-16 20:31:15]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2016-10-16 20:31:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-16 20:40:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-16 20:40:35]

Try jobs failed on following builders:
  win_x64_clang_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_dbg/build...)

[brandtr, 2016-10-16 20:42:41]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2016-10-16 20:42:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-16 21:10:57]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-10-16 21:11:03]

Description was changed from

==========
Add path for recovered packets from internal::Call to RtpStreamReceiver.

When the FlexfecReceiver recovers media packets, it inserts these into
internal::Call, which then distributes them to the appropriate
VideoReceiveStream/RtpStreamReceiver.

BUG=webrtc:5654
==========

to

==========
Add path for recovered packets from internal::Call to RtpStreamReceiver.

When the FlexfecReceiver recovers media packets, it inserts these into
internal::Call, which then distributes them to the appropriate
VideoReceiveStream/RtpStreamReceiver.

BUG=webrtc:5654

Committed: https://crrev.com/9c4b4b47f4325b48e1856566a30983f9e4e30dd0
Cr-Commit-Position: refs/heads/master@{#14642}
==========

[commit-bot: I haz the power, 2016-10-16 21:11:04]

Patchset 2 (id:??) landed as
https://crrev.com/9c4b4b47f4325b48e1856566a30983f9e4e30dd0
Cr-Commit-Position: refs/heads/master@{#14642}

[honghaiz3, 2016-10-17 16:42:14]

A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.webrtc.org/2427733002/ by honghaiz@webrtc.org.

The reason for reverting is: Speculative revert as it may be the cause of the
DrMemory test failure:
https://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Full/bui....