Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2390643002: Move RTCPHelp::RTCPReportBlockInformation into RTCPReceiver (Closed)

Created:
4 years, 2 months ago by danilchap
Modified:
4 years, 2 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move RTCPHelp::RTCPReportBlockInformation into RTCPReceiver removing RTCPHelp namespace and rtcp_receiver_help files, cleaning style of the ReportBlockInformation usage. BUG=webrtc:5565 Committed: https://crrev.com/28b03eb4493d759ad1b84cc6df8e2992ba18f02e Cr-Commit-Position: refs/heads/master@{#14527}

Patch Set 1 #

Patch Set 2 : -diviision by 0 #

Total comments: 2

Patch Set 3 : Fix RtcpReceiverTest.GetRtt #

Patch Set 4 : renames #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -233 lines) Patch
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 1 2 3 5 chunks +11 lines, -21 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 2 3 8 chunks +75 lines, -132 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h View 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
danilchap
Mostly style change. Better rtt calculation still planned in a different dedicated CL.
4 years, 2 months ago (2016-10-03 11:22:20 UTC) #2
philipel
lg https://codereview.webrtc.org/2390643002/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right): https://codereview.webrtc.org/2390643002/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc#newcode90 webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:90: struct RTCPReceiver::ReportBlockInformation { WDYT about |AggregatedRttInfo| instead of ...
4 years, 2 months ago (2016-10-03 12:33:17 UTC) #3
danilchap
https://codereview.webrtc.org/2390643002/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right): https://codereview.webrtc.org/2390643002/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc#newcode90 webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:90: struct RTCPReceiver::ReportBlockInformation { On 2016/10/03 12:33:17, philipel wrote: > ...
4 years, 2 months ago (2016-10-03 16:10:12 UTC) #4
philipel
lgtm
4 years, 2 months ago (2016-10-05 08:04:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2390643002/60001
4 years, 2 months ago (2016-10-05 08:13:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/7013)
4 years, 2 months ago (2016-10-05 08:28:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2390643002/60001
4 years, 2 months ago (2016-10-05 13:13:37 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-05 13:59:48 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 13:59:54 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/28b03eb4493d759ad1b84cc6df8e2992ba18f02e
Cr-Commit-Position: refs/heads/master@{#14527}

Powered by Google App Engine
This is Rietveld 408576698