webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h - Issue 2390463002: Remove OnLocalSsrcChanged and rename EncoderStateFeedback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

Issue 2390463002: Remove OnLocalSsrcChanged and rename EncoderStateFeedback. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

index 648e25dbfec8acb53576298a1307b0df1627168a..a9bbd1eeea004fcfa3d9e52d1cd51eddf7c7ff9e 100644

--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

@@ -221,7 +221,8 @@ class RtcpIntraFrameObserver {

virtual void OnReceivedRPSI(uint32_t ssrc,

uint64_t picture_id) = 0;

- virtual void OnLocalSsrcChanged(uint32_t old_ssrc, uint32_t new_ssrc) = 0;

+ // TODO(mflodman): Remove completely.

+ virtual void OnLocalSsrcChanged(uint32_t old_ssrc, uint32_t new_ssrc) {}

virtual ~RtcpIntraFrameObserver() {}

};