Remove OnLocalSsrcChanged and rename EncoderStateFeedback.

Remove OnLocalSsrcChanged and rename EncoderStateFeedback.

The renaming is to reflect this class is only used for RTCP interaction
and not for other transports.

This Cl will be followed by multiple CLs moving all send-side RTP
functionality to a separate class, rtp module ownership away from
VideoSendStream and use TaskQueue instead of ProcessThread for RTP.

BUG=webrtc:6456
Committed: https://crrev.com/15d8357bab8d6a81417f7225408969f1514257ac
Cr-Commit-Position: refs/heads/master@{#14556}

[mflodman, 2016-10-01 08:36:29]

Description was changed from

==========
Remove OnLocalSsrcChanged and rename EncoderStateFeedback.

The renaming is to reflect this class is only used for RTCP interaction
and not for other transports.

This Cl will be followed by multiple CLs moving all send-side RTP
functionality to a separate class, rtp module ownership away from
VideoSendStream and use TaskQueue instead of ProcessThread for RTP.

BUG=6456
==========

to

==========
Remove OnLocalSsrcChanged and rename EncoderStateFeedback.

The renaming is to reflect this class is only used for RTCP interaction
and not for other transports.

This Cl will be followed by multiple CLs moving all send-side RTP
functionality to a separate class, rtp module ownership away from
VideoSendStream and use TaskQueue instead of ProcessThread for RTP.

BUG=6456
==========

[mflodman, 2016-10-01 08:36:48]

Description was changed from

==========
Remove OnLocalSsrcChanged and rename EncoderStateFeedback.

The renaming is to reflect this class is only used for RTCP interaction
and not for other transports.

This Cl will be followed by multiple CLs moving all send-side RTP
functionality to a separate class, rtp module ownership away from
VideoSendStream and use TaskQueue instead of ProcessThread for RTP.

BUG=6456
==========

to

==========
Remove OnLocalSsrcChanged and rename EncoderStateFeedback.

The renaming is to reflect this class is only used for RTCP interaction
and not for other transports.

This Cl will be followed by multiple CLs moving all send-side RTP
functionality to a separate class, rtp module ownership away from
VideoSendStream and use TaskQueue instead of ProcessThread for RTP.

BUG=webrtc:6456
==========

[mflodman, 2016-10-01 08:50:05]

mflodman@webrtc.org changed reviewers:
+ stefan@webrtc.org

[mflodman, 2016-10-01 08:50:06]

Stefan,
Can you take a look at this CL?

[stefan-webrtc, 2016-10-05 14:20:39]

https://codereview.webrtc.org/2390463002/diff/1/webrtc/video/encoder_rtcp_fee...
File webrtc/video/encoder_rtcp_feedback.h (right):

https://codereview.webrtc.org/2390463002/diff/1/webrtc/video/encoder_rtcp_fee...
webrtc/video/encoder_rtcp_feedback.h:24: class EncoderRtcpFeedback : public
RtcpIntraFrameObserver {
I think this makes sense now, but I think we need a more generic encoder
feedback interface later. Is the plan to move this to RtpStreamSender once you
move RtpRtcp out of VideoSendStream?

[mflodman, 2016-10-05 14:22:52]

https://codereview.webrtc.org/2390463002/diff/1/webrtc/video/encoder_rtcp_fee...
File webrtc/video/encoder_rtcp_feedback.h (right):

https://codereview.webrtc.org/2390463002/diff/1/webrtc/video/encoder_rtcp_fee...
webrtc/video/encoder_rtcp_feedback.h:24: class EncoderRtcpFeedback : public
RtcpIntraFrameObserver {
On 2016/10/05 14:20:38, stefan-webrtc (holmer) wrote:
> I think this makes sense now, but I think we need a more generic encoder
> feedback interface later. Is the plan to move this to RtpStreamSender once you
> move RtpRtcp out of VideoSendStream?

Yes, something like that. Grouping all RTP / RTCP logic in one place.

[stefan-webrtc, 2016-10-06 14:25:53]

lgtm

[mflodman, 2016-10-06 14:58:30]

The CQ bit was checked by mflodman@webrtc.org

[mflodman, 2016-10-06 14:58:30]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2390463002/#ps20001 (title:
"Rebase")

[commit-bot: I haz the power, 2016-10-06 14:58:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-06 15:35:13]

Description was changed from

==========
Remove OnLocalSsrcChanged and rename EncoderStateFeedback.

The renaming is to reflect this class is only used for RTCP interaction
and not for other transports.

This Cl will be followed by multiple CLs moving all send-side RTP
functionality to a separate class, rtp module ownership away from
VideoSendStream and use TaskQueue instead of ProcessThread for RTP.

BUG=webrtc:6456
==========

to

==========
Remove OnLocalSsrcChanged and rename EncoderStateFeedback.

The renaming is to reflect this class is only used for RTCP interaction
and not for other transports.

This Cl will be followed by multiple CLs moving all send-side RTP
functionality to a separate class, rtp module ownership away from
VideoSendStream and use TaskQueue instead of ProcessThread for RTP.

BUG=webrtc:6456
==========

[commit-bot: I haz the power, 2016-10-06 15:35:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 15:35:31]

Description was changed from

==========
Remove OnLocalSsrcChanged and rename EncoderStateFeedback.

The renaming is to reflect this class is only used for RTCP interaction
and not for other transports.

This Cl will be followed by multiple CLs moving all send-side RTP
functionality to a separate class, rtp module ownership away from
VideoSendStream and use TaskQueue instead of ProcessThread for RTP.

BUG=webrtc:6456
==========

to

==========
Remove OnLocalSsrcChanged and rename EncoderStateFeedback.

The renaming is to reflect this class is only used for RTCP interaction
and not for other transports.

This Cl will be followed by multiple CLs moving all send-side RTP
functionality to a separate class, rtp module ownership away from
VideoSendStream and use TaskQueue instead of ProcessThread for RTP.

BUG=webrtc:6456

Committed: https://crrev.com/15d8357bab8d6a81417f7225408969f1514257ac
Cr-Commit-Position: refs/heads/master@{#14556}
==========

[commit-bot: I haz the power, 2016-10-06 15:35:32]

Patchset 2 (id:??) landed as
https://crrev.com/15d8357bab8d6a81417f7225408969f1514257ac
Cr-Commit-Position: refs/heads/master@{#14556}