Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1521)

Issue 2387343002: RTCStatsMember<bool> and RTCStatsMember<std::vector<bool>> added. (Closed)

Created:
4 years, 2 months ago by hbos
Modified:
4 years, 2 months ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCStatsMember<bool> and RTCStatsMember<std::vector<bool>> added. RTCStatsMemberInterface::Type's kBool and kSequenceBool. This means that RTCStats-derived classes ("RTCStats-derived dictionaries"[1]) can contain boolean and sequence of boolean members. [1] https://w3c.github.io/webrtc-stats/ BUG=chromium:627816 NOTRY=True Committed: https://crrev.com/b20f38792ee87d76a0c4a47e05fbd9a8a8789c29 Cr-Commit-Position: refs/heads/master@{#14509}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed spaces between RTCStatsMember and variable name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M webrtc/api/stats/rtcstats.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/stats/rtcstats.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/stats/rtcstats_unittest.cc View 4 chunks +7 lines, -1 line 0 comments Download
M webrtc/stats/test/rtcteststats.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/stats/test/rtcteststats.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
hbos
Please take a look hta
4 years, 2 months ago (2016-10-04 09:11:08 UTC) #2
hta-webrtc
lgtm https://codereview.webrtc.org/2387343002/diff/1/webrtc/stats/test/rtcteststats.h File webrtc/stats/test/rtcteststats.h (right): https://codereview.webrtc.org/2387343002/diff/1/webrtc/stats/test/rtcteststats.h#newcode41 webrtc/stats/test/rtcteststats.h:41: RTCStatsMember<bool> m_bool; Is this clang-format compliant? Clang-format may ...
4 years, 2 months ago (2016-10-04 13:53:45 UTC) #3
hbos
https://codereview.webrtc.org/2387343002/diff/1/webrtc/stats/test/rtcteststats.h File webrtc/stats/test/rtcteststats.h (right): https://codereview.webrtc.org/2387343002/diff/1/webrtc/stats/test/rtcteststats.h#newcode41 webrtc/stats/test/rtcteststats.h:41: RTCStatsMember<bool> m_bool; On 2016/10/04 13:53:45, hta-webrtc wrote: > Is ...
4 years, 2 months ago (2016-10-04 20:24:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2387343002/20001
4 years, 2 months ago (2016-10-04 20:24:33 UTC) #7
hbos
Can't land with the android_arm64_rel queuing longer than timeout, but all other bots are green, ...
4 years, 2 months ago (2016-10-04 21:24:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2387343002/20001
4 years, 2 months ago (2016-10-04 21:25:20 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 21:37:14 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 21:37:20 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b20f38792ee87d76a0c4a47e05fbd9a8a8789c29
Cr-Commit-Position: refs/heads/master@{#14509}

Powered by Google App Engine
This is Rietveld 408576698