Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2387333005: Fix "left shift of negative value" bug (Closed)

Created:
4 years, 2 months ago by kwiberg-webrtc
Modified:
4 years, 2 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix "left shift of negative value" bug The values in question are supposed to be able to be negative. BUG=chromium:653448 Committed: https://crrev.com/05f3ec1356aa2dc924d8366bd94a0eef0666c30f Cr-Commit-Position: refs/heads/master@{#14573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/common_audio/signal_processing/filter_ar.c View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 2 months ago (2016-10-06 10:46:31 UTC) #2
hlundin-webrtc
lgtm
4 years, 2 months ago (2016-10-07 12:40:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2387333005/1
4 years, 2 months ago (2016-10-07 12:51:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 14:38:52 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 14:38:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05f3ec1356aa2dc924d8366bd94a0eef0666c30f
Cr-Commit-Position: refs/heads/master@{#14573}

Powered by Google App Engine
This is Rietveld 408576698