Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2387113005: Drop _oldapi from ACM test file names (Closed)

Created:
4 years, 2 months ago by hlundin-webrtc
Modified:
4 years, 2 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Drop _oldapi from ACM test file names Updating GN files, include paths, and include guards BUG=None NOTRY=True NOPRESUBMIT=true Committed: https://crrev.com/2504c0a91c2923905a59f85d4e1c9675135648a0 Cr-Commit-Position: refs/heads/master@{#14542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2959 lines) Patch
M webrtc/modules/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_receive_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_receive_test.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/audio_coding/acm2/acm_receive_test_oldapi.h View 1 chunk +0 lines, -102 lines 0 comments Download
D webrtc/modules/audio_coding/acm2/acm_receive_test_oldapi.cc View 1 chunk +0 lines, -242 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_receiver_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D webrtc/modules/audio_coding/acm2/acm_receiver_unittest_oldapi.cc View 1 chunk +0 lines, -509 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_send_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_send_test.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.h View 1 chunk +0 lines, -88 lines 0 comments Download
D webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.cc View 1 chunk +0 lines, -160 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/audio_coding_module_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc View 1 chunk +0 lines, -1843 lines 0 comments Download

Dependent Patchsets:

Issue 2389263003 Patch 1

Messages

Total messages: 12 (6 generated)
hlundin-webrtc
PTAL
4 years, 2 months ago (2016-10-05 13:19:26 UTC) #3
kwiberg-webrtc
lgtm
4 years, 2 months ago (2016-10-06 08:19:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2387113005/1
4 years, 2 months ago (2016-10-06 08:21:17 UTC) #6
hlundin-webrtc
On 2016/10/06 08:21:17, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 2 months ago (2016-10-06 08:27:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 08:31:35 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 08:31:49 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2504c0a91c2923905a59f85d4e1c9675135648a0
Cr-Commit-Position: refs/heads/master@{#14542}

Powered by Google App Engine
This is Rietveld 408576698