Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2386963003: Replace FileWrapper with File (in audio_device) (Closed)

Created:
4 years, 2 months ago by palmkvist
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removes all uses of FileWrapper in audio_device. BUG=webrtc:6463 Committed: https://crrev.com/04055e95bf97d106053d90bcc9e974eb4ad175e6 Cr-Commit-Position: refs/heads/master@{#14811}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -92 lines) Patch
M webrtc/modules/audio_device/audio_device_buffer.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_device/dummy/file_audio_device.h View 4 chunks +6 lines, -7 lines 0 comments Download
M webrtc/modules/audio_device/dummy/file_audio_device.cc View 7 chunks +77 lines, -83 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
palmkvist
I'm replacing the somewhat overly complicated FileWrapper with a simpler wrapper in rtc_base. Usage is ...
4 years, 2 months ago (2016-10-18 14:13:48 UTC) #4
palmkvist
I'm replacing the somewhat overly complicated FileWrapper with a simpler wrapper in rtc_base. Usage is ...
4 years, 2 months ago (2016-10-19 09:58:34 UTC) #6
sprang_webrtc
lgtm for file part This code really needs to be brought up date re coding ...
4 years, 2 months ago (2016-10-19 09:59:09 UTC) #8
sprang_webrtc
-xians2 +henrika as owner
4 years, 2 months ago (2016-10-20 07:53:02 UTC) #10
sprang_webrtc
ping?
4 years, 1 month ago (2016-10-26 13:44:15 UTC) #11
henrika_webrtc
LGTM
4 years, 1 month ago (2016-10-26 14:00:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2386963003/40001
4 years, 1 month ago (2016-10-27 13:00:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/2517)
4 years, 1 month ago (2016-10-27 13:29:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2386963003/40001
4 years, 1 month ago (2016-10-28 08:57:06 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-28 09:08:26 UTC) #20
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/04055e95bf97d106053d90bcc9e974eb4ad175e6 Cr-Commit-Position: refs/heads/master@{#14811}
4 years, 1 month ago (2016-10-28 09:08:36 UTC) #22
terelius
4 years, 1 month ago (2016-10-28 13:51:47 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2459873002/ by terelius@webrtc.org.

The reason for reverting is: Speculative revert. This CL is a plausible cause
for breakages in internal projects..

Powered by Google App Engine
This is Rietveld 408576698