Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: webrtc/p2p/base/transportchannelimpl.h

Issue 2386783002: Add UMA metrics for ICE regathering reasons. (Closed)
Patch Set: Add const to the pooled_sessions method. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/p2p/base/portallocator.h ('k') | webrtc/p2p/base/transportcontroller.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_ 11 #ifndef WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_
12 #define WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_ 12 #define WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_
13 13
14 #include <string> 14 #include <string>
15 15
16 #include "webrtc/base/constructormagic.h" 16 #include "webrtc/base/constructormagic.h"
17 #include "webrtc/p2p/base/transportchannel.h" 17 #include "webrtc/p2p/base/transportchannel.h"
18 18
19 namespace buzz { class XmlElement; } 19 namespace buzz { class XmlElement; }
20 20
21 namespace webrtc {
22 class MetricsObserverInterface;
23 }
24
21 namespace cricket { 25 namespace cricket {
22 26
23 class Candidate; 27 class Candidate;
24 28
25 // TODO(pthatcher): Remove this once it's no longer used in 29 // TODO(pthatcher): Remove this once it's no longer used in
26 // remoting/protocol/libjingle_transport_factory.cc 30 // remoting/protocol/libjingle_transport_factory.cc
27 enum IceProtocolType { 31 enum IceProtocolType {
28 ICEPROTO_RFC5245 // Standard RFC 5245 version of ICE. 32 ICEPROTO_RFC5245 // Standard RFC 5245 version of ICE.
29 }; 33 };
30 34
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 71
68 // SetRemoteIceMode must be implemented only by the ICE transport channels. 72 // SetRemoteIceMode must be implemented only by the ICE transport channels.
69 virtual void SetRemoteIceMode(IceMode mode) = 0; 73 virtual void SetRemoteIceMode(IceMode mode) = 0;
70 74
71 virtual void SetIceConfig(const IceConfig& config) = 0; 75 virtual void SetIceConfig(const IceConfig& config) = 0;
72 76
73 // Start gathering candidates if not already started, or if an ICE restart 77 // Start gathering candidates if not already started, or if an ICE restart
74 // occurred. 78 // occurred.
75 virtual void MaybeStartGathering() = 0; 79 virtual void MaybeStartGathering() = 0;
76 80
81 virtual void SetMetricsObserver(
82 webrtc::MetricsObserverInterface* observer) = 0;
83
77 sigslot::signal1<TransportChannelImpl*> SignalGatheringState; 84 sigslot::signal1<TransportChannelImpl*> SignalGatheringState;
78 85
79 // Handles sending and receiving of candidates. The Transport 86 // Handles sending and receiving of candidates. The Transport
80 // receives the candidates and may forward them to the relevant 87 // receives the candidates and may forward them to the relevant
81 // channel. 88 // channel.
82 // 89 //
83 // Note: Since candidates are delivered asynchronously to the 90 // Note: Since candidates are delivered asynchronously to the
84 // channel, they cannot return an error if the message is invalid. 91 // channel, they cannot return an error if the message is invalid.
85 // It is assumed that the Transport will have checked validity 92 // It is assumed that the Transport will have checked validity
86 // before forwarding. 93 // before forwarding.
(...skipping 27 matching lines...) Expand all
114 // Emitted whenever the Dtls handshake failed on some transport channel. 121 // Emitted whenever the Dtls handshake failed on some transport channel.
115 sigslot::signal1<rtc::SSLHandshakeError> SignalDtlsHandshakeError; 122 sigslot::signal1<rtc::SSLHandshakeError> SignalDtlsHandshakeError;
116 123
117 private: 124 private:
118 RTC_DISALLOW_COPY_AND_ASSIGN(TransportChannelImpl); 125 RTC_DISALLOW_COPY_AND_ASSIGN(TransportChannelImpl);
119 }; 126 };
120 127
121 } // namespace cricket 128 } // namespace cricket
122 129
123 #endif // WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_ 130 #endif // WEBRTC_P2P_BASE_TRANSPORTCHANNELIMPL_H_
OLDNEW
« no previous file with comments | « webrtc/p2p/base/portallocator.h ('k') | webrtc/p2p/base/transportcontroller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698