Issue 2386253003: Android: Move layout measure code from SurfaceViewRenderer to RendererCommon

Issue 2386253003: Android: Move layout measure code from SurfaceViewRenderer to RendererCommon (Closed)

Created:
4 years, 2 months ago by magjed_webrtc

Modified:
4 years, 2 months ago

Reviewers:
sakal

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Android: Move layout measure code from SurfaceViewRenderer to RendererCommon BUG=webrtc:6470 R=sakal@webrtc.org Committed: https://crrev.com/62b1c35d300152c456102a304104953af6c781b4 Cr-Commit-Position: refs/heads/master@{#14526}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -48 lines)			Patch
M	webrtc/api/android/java/src/org/webrtc/RendererCommon.java	View		2 chunks	+51 lines, -0 lines	0 comments	Download
M	webrtc/api/android/java/src/org/webrtc/SurfaceViewRenderer.java	View	1	6 chunks	+24 lines, -47 lines	0 comments	Download
M	webrtc/api/androidtests/src/org/webrtc/SurfaceViewRendererOnMeasureTest.java	View	1 2	3 chunks	+3 lines, -1 line	0 comments	Download
M	webrtc/base/java/src/org/webrtc/ThreadUtils.java	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Total messages: 11 (5 generated)

magjed_webrtc

On 2016/10/05 09:36:14, sakal wrote: > The changes look good but please fix the tests. ...

4 years, 2 months ago (2016-10-05 11:05:00 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2386253003/40001

4 years, 2 months ago (2016-10-05 12:18:37 UTC) #8

magjed_webrtc

4 years, 2 months ago (2016-10-05 13:56:21 UTC) #10

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
62b1c35d300152c456102a304104953af6c781b4 (presubmit successful).