Add stats for frequency offset when converting RTP timestamp to NTP time.

Add stats for frequency offset when converting RTP timestamp to NTP time.

- Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

  The absolute value of the difference between the estimated frequency during RTP timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is measured per received video frame. The max offset during 40 second intervals is stored. The average of these stored offsets per received video stream is recorded when a stream is removed.

Updated rtp_to_ntp.cc:
- Add validation for only inserting newer RTCP sender reports to the rtcp list.

- Move calculation of frequency/offset (from RTP/NTP timestamp pairs) to UpdateRtcpList. Calculated when a new RTCP SR in inserted (and not in RtpToNtpMs per packet).

BUG=webrtc:6579
Committed: https://crrev.com/de9e5fffa21401df94fd89b15be5e549cbe3e142
Cr-Commit-Position: refs/heads/master@{#14891}

[åsapersson, 2016-10-05 06:34:30]

Description was changed from

==========
Make process interval configurable for MaxCounter class.

BUG=
==========

to

==========
Add stats for estimated frequency offset when converting RTP timestamp to NTP
time.

Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

The absolute value of the difference between the estimated frequency during RTP
timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is measured
per received video frame. The max offset during 40 second intervals is stored.
The average of these stored offsets per received video stream is recorded when a
stream is removed. 

BUG=b/31154867
==========

[åsapersson, 2016-10-05 12:25:47]

asapersson@webrtc.org changed reviewers:
+ mflodman@webrtc.org, stefan@webrtc.org

[åsapersson, 2016-10-05 12:28:25]

Description was changed from

==========
Add stats for estimated frequency offset when converting RTP timestamp to NTP
time.

Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

The absolute value of the difference between the estimated frequency during RTP
timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is measured
per received video frame. The max offset during 40 second intervals is stored.
The average of these stored offsets per received video stream is recorded when a
stream is removed. 

BUG=b/31154867
==========

to

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

The absolute value of the difference between the estimated frequency during RTP
timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is measured
per received video frame. The max offset during 40 second intervals is stored.
The average of these stored offsets per received video stream is recorded when a
stream is removed. 

BUG=b/31154867
==========

[stefan-webrtc, 2016-10-05 14:35:46]

https://codereview.webrtc.org/2385763002/diff/80001/webrtc/system_wrappers/so...
File webrtc/system_wrappers/source/rtp_to_ntp.cc (right):

https://codereview.webrtc.org/2385763002/diff/80001/webrtc/system_wrappers/so...
webrtc/system_wrappers/source/rtp_to_ntp.cc:104: bool
RtpToNtpMsAndReturnFreq(int64_t rtp_timestamp,
Instead of introducing this slightly odd function, could we instead split it up
in two?

bool GetRtpToNtpParameters(const RtcpList& rtcp, double*
estimated_frequency_khz, double* estimated_offset)

and 

bool RtpToNtpMs(int64_t rtp_timestamp, double rtp_frequency, double offset,
int64_t* rtp_timestamp_in_ms)

[åsapersson, 2016-10-06 14:40:35]

Patchset #6 (id:100001) has been deleted

[åsapersson, 2016-10-06 14:41:38]

Patchset #6 (id:120001) has been deleted

[åsapersson, 2016-10-06 15:36:06]

Patchset #6 (id:140001) has been deleted

[åsapersson, 2016-10-07 13:40:20]

Description was changed from

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

The absolute value of the difference between the estimated frequency during RTP
timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is measured
per received video frame. The max offset during 40 second intervals is stored.
The average of these stored offsets per received video stream is recorded when a
stream is removed. 

BUG=b/31154867
==========

to

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

- Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

- The absolute value of the difference between the estimated frequency during
RTP timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is
measured per received video frame. The max offset during 40 second intervals is
stored. The average of these stored offsets per received video stream is
recorded when a stream is removed.

RtpToNtp.cc:
 - Add validation for only inserting newer RTCP sender reports to the rtcp list.

- Move calculation of frequency/offset (from RTP/NTP timestamp pairs) to
UpdateRtcpList. Calculated when a new RTCP SR in inserted (and not in RtpToNtpMs
per packet).

BUG=b/31154867
==========

[åsapersson, 2016-10-07 13:41:15]

Description was changed from

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

- Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

- The absolute value of the difference between the estimated frequency during
RTP timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is
measured per received video frame. The max offset during 40 second intervals is
stored. The average of these stored offsets per received video stream is
recorded when a stream is removed.

RtpToNtp.cc:
 - Add validation for only inserting newer RTCP sender reports to the rtcp list.

- Move calculation of frequency/offset (from RTP/NTP timestamp pairs) to
UpdateRtcpList. Calculated when a new RTCP SR in inserted (and not in RtpToNtpMs
per packet).

BUG=b/31154867
==========

to

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

- Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

- The absolute value of the difference between the estimated frequency during
RTP timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is
measured per received video frame. The max offset during 40 second intervals is
stored. The average of these stored offsets per received video stream is
recorded when a stream is removed.

rtp_to_ntp.cc:
- Add validation for only inserting newer RTCP sender reports to the rtcp list.

- Move calculation of frequency/offset (from RTP/NTP timestamp pairs) to
UpdateRtcpList. Calculated when a new RTCP SR in inserted (and not in RtpToNtpMs
per packet).

BUG=b/31154867
==========

[åsapersson, 2016-10-07 13:41:39]

Description was changed from

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

- Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

- The absolute value of the difference between the estimated frequency during
RTP timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is
measured per received video frame. The max offset during 40 second intervals is
stored. The average of these stored offsets per received video stream is
recorded when a stream is removed.

rtp_to_ntp.cc:
- Add validation for only inserting newer RTCP sender reports to the rtcp list.

- Move calculation of frequency/offset (from RTP/NTP timestamp pairs) to
UpdateRtcpList. Calculated when a new RTCP SR in inserted (and not in RtpToNtpMs
per packet).

BUG=b/31154867
==========

to

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

- Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

- The absolute value of the difference between the estimated frequency during
RTP timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is
measured per received video frame. The max offset during 40 second intervals is
stored. The average of these stored offsets per received video stream is
recorded when a stream is removed.

Updated rtp_to_ntp.cc:
- Add validation for only inserting newer RTCP sender reports to the rtcp list.

- Move calculation of frequency/offset (from RTP/NTP timestamp pairs) to
UpdateRtcpList. Calculated when a new RTCP SR in inserted (and not in RtpToNtpMs
per packet).

BUG=b/31154867
==========

[åsapersson, 2016-10-07 13:42:28]

Description was changed from

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

- Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

- The absolute value of the difference between the estimated frequency during
RTP timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is
measured per received video frame. The max offset during 40 second intervals is
stored. The average of these stored offsets per received video stream is
recorded when a stream is removed.

Updated rtp_to_ntp.cc:
- Add validation for only inserting newer RTCP sender reports to the rtcp list.

- Move calculation of frequency/offset (from RTP/NTP timestamp pairs) to
UpdateRtcpList. Calculated when a new RTCP SR in inserted (and not in RtpToNtpMs
per packet).

BUG=b/31154867
==========

to

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

- Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

  The absolute value of the difference between the estimated frequency during
RTP timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is
measured per received video frame. The max offset during 40 second intervals is
stored. The average of these stored offsets per received video stream is
recorded when a stream is removed.

Updated rtp_to_ntp.cc:
- Add validation for only inserting newer RTCP sender reports to the rtcp list.

- Move calculation of frequency/offset (from RTP/NTP timestamp pairs) to
UpdateRtcpList. Calculated when a new RTCP SR in inserted (and not in RtpToNtpMs
per packet).

BUG=b/31154867
==========

[åsapersson, 2016-10-09 13:50:00]

Patchset #8 (id:200001) has been deleted

[åsapersson, 2016-10-09 13:50:29]

Patchset #7 (id:180001) has been deleted

[åsapersson, 2016-10-09 14:17:38]

Patchset #8 (id:240001) has been deleted

[åsapersson, 2016-10-09 14:17:55]

Patchset #7 (id:220001) has been deleted

[åsapersson, 2016-10-09 14:22:15]

https://codereview.webrtc.org/2385763002/diff/80001/webrtc/system_wrappers/so...
File webrtc/system_wrappers/source/rtp_to_ntp.cc (right):

https://codereview.webrtc.org/2385763002/diff/80001/webrtc/system_wrappers/so...
webrtc/system_wrappers/source/rtp_to_ntp.cc:104: bool
RtpToNtpMsAndReturnFreq(int64_t rtp_timestamp,
On 2016/10/05 14:35:46, stefan-webrtc (holmer) wrote:
> Instead of introducing this slightly odd function, could we instead split it
up
> in two?
> 
> bool GetRtpToNtpParameters(const RtcpList& rtcp, double*
> estimated_frequency_khz, double* estimated_offset)
> 
> and 
> 
> bool RtpToNtpMs(int64_t rtp_timestamp, double rtp_frequency, double offset,
> int64_t* rtp_timestamp_in_ms)

The old timestamp in the RctpList is used in RtpToNtpMs to check for wrap
around. I updated the cl so the parameters are calculated when the rtcp list is
updated, ptal.

[stefan-webrtc, 2016-10-18 23:38:27]

https://codereview.webrtc.org/2385763002/diff/260001/webrtc/system_wrappers/s...
File webrtc/system_wrappers/source/rtp_to_ntp.cc (right):

https://codereview.webrtc.org/2385763002/diff/260001/webrtc/system_wrappers/s...
webrtc/system_wrappers/source/rtp_to_ntp.cc:57: return (ntp_secs ==
other.ntp_secs && ntp_frac == other.ntp_frac) ||
Why ||? Comment on that (I assume it's because we want unique points in both x
and y to be able to estimate the line.

https://codereview.webrtc.org/2385763002/diff/260001/webrtc/system_wrappers/s...
File webrtc/system_wrappers/source/rtp_to_ntp_unittest.cc (right):

https://codereview.webrtc.org/2385763002/diff/260001/webrtc/system_wrappers/s...
webrtc/system_wrappers/source/rtp_to_ntp_unittest.cc:159:
TEST(UpdateRtcpListTests, FailsForZeroNtp) {
Could you comment on why we decide to fail on zero ntp?

[åsapersson, 2016-10-19 14:35:28]

https://codereview.webrtc.org/2385763002/diff/260001/webrtc/system_wrappers/s...
File webrtc/system_wrappers/source/rtp_to_ntp.cc (right):

https://codereview.webrtc.org/2385763002/diff/260001/webrtc/system_wrappers/s...
webrtc/system_wrappers/source/rtp_to_ntp.cc:57: return (ntp_secs ==
other.ntp_secs && ntp_frac == other.ntp_frac) ||
On 2016/10/18 23:38:27, stefan-webrtc (holmer) wrote:
> Why ||? Comment on that (I assume it's because we want unique points in both x
> and y to be able to estimate the line.

Done.

https://codereview.webrtc.org/2385763002/diff/260001/webrtc/system_wrappers/s...
File webrtc/system_wrappers/source/rtp_to_ntp_unittest.cc (right):

https://codereview.webrtc.org/2385763002/diff/260001/webrtc/system_wrappers/s...
webrtc/system_wrappers/source/rtp_to_ntp_unittest.cc:159:
TEST(UpdateRtcpListTests, FailsForZeroNtp) {
On 2016/10/18 23:38:27, stefan-webrtc (holmer) wrote:
> Could you comment on why we decide to fail on zero ntp?

Done. Added comment.

[åsapersson, 2016-10-20 08:17:34]

Patchset #10 (id:320001) has been deleted

[åsapersson, 2016-10-21 07:33:16]

Description was changed from

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

- Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

  The absolute value of the difference between the estimated frequency during
RTP timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is
measured per received video frame. The max offset during 40 second intervals is
stored. The average of these stored offsets per received video stream is
recorded when a stream is removed.

Updated rtp_to_ntp.cc:
- Add validation for only inserting newer RTCP sender reports to the rtcp list.

- Move calculation of frequency/offset (from RTP/NTP timestamp pairs) to
UpdateRtcpList. Calculated when a new RTCP SR in inserted (and not in RtpToNtpMs
per packet).

BUG=b/31154867
==========

to

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

- Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

  The absolute value of the difference between the estimated frequency during
RTP timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is
measured per received video frame. The max offset during 40 second intervals is
stored. The average of these stored offsets per received video stream is
recorded when a stream is removed.

Updated rtp_to_ntp.cc:
- Add validation for only inserting newer RTCP sender reports to the rtcp list.

- Move calculation of frequency/offset (from RTP/NTP timestamp pairs) to
UpdateRtcpList. Calculated when a new RTCP SR in inserted (and not in RtpToNtpMs
per packet).

BUG=webrtc:6579
==========

[åsapersson, 2016-10-21 09:49:26]

Patchset #10 (id:340001) has been deleted

[stefan-webrtc, 2016-11-01 13:48:55]

lg

https://codereview.webrtc.org/2385763002/diff/380001/webrtc/system_wrappers/i...
File webrtc/system_wrappers/include/rtp_to_ntp.h (right):

https://codereview.webrtc.org/2385763002/diff/380001/webrtc/system_wrappers/i...
webrtc/system_wrappers/include/rtp_to_ntp.h:30: struct RtcpMeasurements {
Maybe this should be a class now that it has so many non trivial methods.

[åsapersson, 2016-11-01 14:03:11]

https://codereview.webrtc.org/2385763002/diff/380001/webrtc/system_wrappers/i...
File webrtc/system_wrappers/include/rtp_to_ntp.h (right):

https://codereview.webrtc.org/2385763002/diff/380001/webrtc/system_wrappers/i...
webrtc/system_wrappers/include/rtp_to_ntp.h:30: struct RtcpMeasurements {
On 2016/11/01 13:48:55, stefan-webrtc (holmer) wrote:
> Maybe this should be a class now that it has so many non trivial methods.

Yes, I thought about making a class with UpdateRtcpList, RtpToNtpMs,
frequency_khz() as public methods and the rest private, but maybe in a follow up
CL. Or wdyt?

[stefan-webrtc, 2016-11-01 15:19:26]

lgtm

https://codereview.webrtc.org/2385763002/diff/380001/webrtc/system_wrappers/i...
File webrtc/system_wrappers/include/rtp_to_ntp.h (right):

https://codereview.webrtc.org/2385763002/diff/380001/webrtc/system_wrappers/i...
webrtc/system_wrappers/include/rtp_to_ntp.h:30: struct RtcpMeasurements {
On 2016/11/01 14:03:11, åsapersson wrote:
> On 2016/11/01 13:48:55, stefan-webrtc (holmer) wrote:
> > Maybe this should be a class now that it has so many non trivial methods.
> 
> Yes, I thought about making a class with UpdateRtcpList, RtpToNtpMs,
> frequency_khz() as public methods and the rest private, but maybe in a follow
up
> CL. Or wdyt? 

Sure sgtm

[åsapersson, 2016-11-02 14:12:06]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2016-11-02 14:12:06]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2385763002/#ps400001 (title:
"rebase")

[commit-bot: I haz the power, 2016-11-02 14:12:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-02 14:14:06]

Description was changed from

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

- Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

  The absolute value of the difference between the estimated frequency during
RTP timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is
measured per received video frame. The max offset during 40 second intervals is
stored. The average of these stored offsets per received video stream is
recorded when a stream is removed.

Updated rtp_to_ntp.cc:
- Add validation for only inserting newer RTCP sender reports to the rtcp list.

- Move calculation of frequency/offset (from RTP/NTP timestamp pairs) to
UpdateRtcpList. Calculated when a new RTCP SR in inserted (and not in RtpToNtpMs
per packet).

BUG=webrtc:6579
==========

to

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

- Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

  The absolute value of the difference between the estimated frequency during
RTP timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is
measured per received video frame. The max offset during 40 second intervals is
stored. The average of these stored offsets per received video stream is
recorded when a stream is removed.

Updated rtp_to_ntp.cc:
- Add validation for only inserting newer RTCP sender reports to the rtcp list.

- Move calculation of frequency/offset (from RTP/NTP timestamp pairs) to
UpdateRtcpList. Calculated when a new RTCP SR in inserted (and not in RtpToNtpMs
per packet).

BUG=webrtc:6579
==========

[commit-bot: I haz the power, 2016-11-02 14:14:07]

Committed patchset #12 (id:400001)

[commit-bot: I haz the power, 2016-11-02 14:14:13]

Description was changed from

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

- Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

  The absolute value of the difference between the estimated frequency during
RTP timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is
measured per received video frame. The max offset during 40 second intervals is
stored. The average of these stored offsets per received video stream is
recorded when a stream is removed.

Updated rtp_to_ntp.cc:
- Add validation for only inserting newer RTCP sender reports to the rtcp list.

- Move calculation of frequency/offset (from RTP/NTP timestamp pairs) to
UpdateRtcpList. Calculated when a new RTCP SR in inserted (and not in RtpToNtpMs
per packet).

BUG=webrtc:6579
==========

to

==========
Add stats for frequency offset when converting RTP timestamp to NTP time.

- Add histogram: "WebRTC.Video.RtpToNtpFreqOffsetInKhz"

  The absolute value of the difference between the estimated frequency during
RTP timestamp to NTP time conversion and the actual value (i.e. 90 kHz) is
measured per received video frame. The max offset during 40 second intervals is
stored. The average of these stored offsets per received video stream is
recorded when a stream is removed.

Updated rtp_to_ntp.cc:
- Add validation for only inserting newer RTCP sender reports to the rtcp list.

- Move calculation of frequency/offset (from RTP/NTP timestamp pairs) to
UpdateRtcpList. Calculated when a new RTCP SR in inserted (and not in RtpToNtpMs
per packet).

BUG=webrtc:6579

Committed: https://crrev.com/de9e5fffa21401df94fd89b15be5e549cbe3e142
Cr-Commit-Position: refs/heads/master@{#14891}
==========

[commit-bot: I haz the power, 2016-11-02 14:14:14]

Patchset 12 (id:??) landed as
https://crrev.com/de9e5fffa21401df94fd89b15be5e549cbe3e142
Cr-Commit-Position: refs/heads/master@{#14891}