Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2385563002: Revert of Replace RelayPort with TurnPort in p2ptransportchannel tests. (Closed)

Created:
4 years, 2 months ago by honghaiz3
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Replace RelayPort with TurnPort in p2ptransportchannel tests. (patchset #2 id:40001 of https://codereview.webrtc.org/2380923002/ ) Reason for revert: It caused some tests in p2ptransportchannel flaky. Original issue's description: > Replace RelayPort with TurnPort in p2ptransportchannel tests. > > Also remove the relay servers in the tests. > Most of the code and the downstream apps are using TurnPort, not RelayPort. Most of the tests in this file are not using RelayPort anyway. > > BUG=None > R=deadbeef@webrtc.org > > Committed: https://crrev.com/c8d21712dde64c7d613d1ea56c840438505a909f > Cr-Commit-Position: refs/heads/master@{#14441} TBR=deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/75f662671829b6982697919ef6ac1546a1f5bedd Cr-Commit-Position: refs/heads/master@{#14443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -32 lines) Patch
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 7 chunks +44 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
honghaiz3
Created Revert of Replace RelayPort with TurnPort in p2ptransportchannel tests.
4 years, 2 months ago (2016-09-30 01:17:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2385563002/1
4 years, 2 months ago (2016-09-30 01:17:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 01:17:32 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 01:17:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75f662671829b6982697919ef6ac1546a1f5bedd
Cr-Commit-Position: refs/heads/master@{#14443}

Powered by Google App Engine
This is Rietveld 408576698