Revert "Revert of Use sps and pps to determine decodability of H.264 frames. (patchset #4 id:60001 …

Revert "Revert of Use sps and pps to determine decodability of H.264 frames. (patchset #4 id:60001 of https://codereview.webrtc.org/2341713002/ )"

This reverts commit 3cdfcd88a14449a9b116cb6149e1348d3a1e4cb2.

NOPRESUBMIT=true
BUG=webrtc:6208
Committed: https://crrev.com/a669a3a0dc9d20313c3e437d4c0ed5003f545727
Cr-Commit-Position: refs/heads/master@{#14551}

[stefan-webrtc, 2016-10-05 15:42:27]

stefan@webrtc.org changed reviewers:
+ philipel@webrtc.org

[stefan-webrtc, 2016-10-05 15:42:28]

I've made some fixes and would like to reland this. PTAL, especially the diff
against PS1 which is the original CL.

[stefan-webrtc, 2016-10-05 15:43:24]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 15:43:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-05 15:53:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 15:53:18]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8994)

[philipel, 2016-10-06 10:49:47]

https://codereview.webrtc.org/2385143002/diff/50001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/decoding_state.cc (right):

https://codereview.webrtc.org/2385143002/diff/50001/webrtc/modules/video_codi...
webrtc/modules/video_coding/decoding_state.cc:211:
HaveSpsAndPps(frame->GetNaluInfos())) {
Can a h264 frame ever not have nalus? In that case we wont check if we have the
necessary sps/pps for that frame.

https://codereview.webrtc.org/2385143002/diff/50001/webrtc/modules/video_codi...
webrtc/modules/video_coding/decoding_state.cc:337: int sps_needed = -1;
|sps_needed| sounds like you want to determine if you need an sps at all, I
think |needed_sps| is clearer.

[stefan-webrtc, 2016-10-06 10:58:40]

.

[stefan-webrtc, 2016-10-06 11:00:02]

https://codereview.webrtc.org/2385143002/diff/50001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/decoding_state.cc (right):

https://codereview.webrtc.org/2385143002/diff/50001/webrtc/modules/video_codi...
webrtc/modules/video_coding/decoding_state.cc:211:
HaveSpsAndPps(frame->GetNaluInfos())) {
On 2016/10/06 10:49:47, philipel wrote:
> Can a h264 frame ever not have nalus? In that case we wont check if we have
the
> necessary sps/pps for that frame.

Right, it shouldn't be possible, except if we'd pass in empty frames for some
reason. And if we don't have nalus we can't know what pps it depends on anyway.
:)

https://codereview.webrtc.org/2385143002/diff/50001/webrtc/modules/video_codi...
webrtc/modules/video_coding/decoding_state.cc:337: int sps_needed = -1;
On 2016/10/06 10:49:47, philipel wrote:
> |sps_needed| sounds like you want to determine if you need an sps at all, I
> think |needed_sps| is clearer.

Done.

[philipel, 2016-10-06 11:10:51]

lgtm

https://codereview.webrtc.org/2385143002/diff/50001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/decoding_state.cc (right):

https://codereview.webrtc.org/2385143002/diff/50001/webrtc/modules/video_codi...
webrtc/modules/video_coding/decoding_state.cc:211:
HaveSpsAndPps(frame->GetNaluInfos())) {
On 2016/10/06 11:00:02, stefan-webrtc (holmer) wrote:
> On 2016/10/06 10:49:47, philipel wrote:
> > Can a h264 frame ever not have nalus? In that case we wont check if we have
> the
> > necessary sps/pps for that frame.
> 
> Right, it shouldn't be possible, except if we'd pass in empty frames for some
> reason. And if we don't have nalus we can't know what pps it depends on
anyway.
> :)

Right, so if we have a valid h264 frame then it must have nalus.

[stefan-webrtc, 2016-10-06 11:12:09]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2016-10-06 11:12:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-06 12:00:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 12:01:00]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9028)

[stefan-webrtc, 2016-10-06 12:04:27]

Description was changed from

==========
Revert "Revert of Use sps and pps to determine decodability of H.264 frames.
(patchset #4 id:60001 of https://codereview.webrtc.org/2341713002/ )"

This reverts commit 3cdfcd88a14449a9b116cb6149e1348d3a1e4cb2.

BUG=webrtc:6208
==========

to

==========
Revert "Revert of Use sps and pps to determine decodability of H.264 frames.
(patchset #4 id:60001 of https://codereview.webrtc.org/2341713002/ )"

This reverts commit 3cdfcd88a14449a9b116cb6149e1348d3a1e4cb2.

NOPRESUBMIT=true
BUG=webrtc:6208
==========

[stefan-webrtc, 2016-10-06 12:04:33]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2016-10-06 12:04:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-06 12:04:54]

Description was changed from

==========
Revert "Revert of Use sps and pps to determine decodability of H.264 frames.
(patchset #4 id:60001 of https://codereview.webrtc.org/2341713002/ )"

This reverts commit 3cdfcd88a14449a9b116cb6149e1348d3a1e4cb2.

NOPRESUBMIT=true
BUG=webrtc:6208
==========

to

==========
Revert "Revert of Use sps and pps to determine decodability of H.264 frames.
(patchset #4 id:60001 of https://codereview.webrtc.org/2341713002/ )"

This reverts commit 3cdfcd88a14449a9b116cb6149e1348d3a1e4cb2.

NOPRESUBMIT=true
BUG=webrtc:6208
==========

[commit-bot: I haz the power, 2016-10-06 12:04:55]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2016-10-06 12:05:03]

Description was changed from

==========
Revert "Revert of Use sps and pps to determine decodability of H.264 frames.
(patchset #4 id:60001 of https://codereview.webrtc.org/2341713002/ )"

This reverts commit 3cdfcd88a14449a9b116cb6149e1348d3a1e4cb2.

NOPRESUBMIT=true
BUG=webrtc:6208
==========

to

==========
Revert "Revert of Use sps and pps to determine decodability of H.264 frames.
(patchset #4 id:60001 of https://codereview.webrtc.org/2341713002/ )"

This reverts commit 3cdfcd88a14449a9b116cb6149e1348d3a1e4cb2.

NOPRESUBMIT=true
BUG=webrtc:6208

Committed: https://crrev.com/a669a3a0dc9d20313c3e437d4c0ed5003f545727
Cr-Commit-Position: refs/heads/master@{#14551}
==========

[commit-bot: I haz the power, 2016-10-06 12:05:05]

Patchset 5 (id:??) landed as
https://crrev.com/a669a3a0dc9d20313c3e437d4c0ed5003f545727
Cr-Commit-Position: refs/heads/master@{#14551}