Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2385053004: Delete unused code, cpuinfo.{h,cc}. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused code, cpuinfo.{h,cc}. BUG=webrtc:6424 Committed: https://crrev.com/4e8baf46a74f853b68f235e5617ed5385b946f37 Cr-Commit-Position: refs/heads/master@{#14538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -183 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/media/base/cpuid.h View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/media/base/cpuid.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D webrtc/media/base/cpuid_unittest.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M webrtc/media/media.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nisse-webrtc
This unused. There's a slightly related webrtc/system_wrappers/include/cpu_info.h, declaring a static function DetectNumberOfCores.
4 years, 2 months ago (2016-10-04 13:07:58 UTC) #2
pthatcher1
lgtm
4 years, 2 months ago (2016-10-04 15:45:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2385053004/1
4 years, 2 months ago (2016-10-05 07:20:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-05 09:21:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2385053004/1
4 years, 2 months ago (2016-10-06 06:43:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 06:44:43 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 06:44:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e8baf46a74f853b68f235e5617ed5385b946f37
Cr-Commit-Position: refs/heads/master@{#14538}

Powered by Google App Engine
This is Rietveld 408576698