webrtc/media/sctp/sctpdataengine.cc - Issue 2384693002: Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/sctp/sctpdataengine.cc

Issue 2384693002: Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere (Closed)

Patch Set: !!! Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/sctp/sctpdataengine.cc

diff --git a/webrtc/media/sctp/sctpdataengine.cc b/webrtc/media/sctp/sctpdataengine.cc

index a724b2af69a5df86293f828e7bde4e2a7b2da796..0804fed76916017da61fcb2a427658073f109b54 100644

--- a/webrtc/media/sctp/sctpdataengine.cc

+++ b/webrtc/media/sctp/sctpdataengine.cc

@@ -118,7 +118,7 @@ enum {

// Helper for logging SCTP messages.

void DebugSctpPrintf(const char* format, ...) {

-#if (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON))

+#if RTC_DCHECK_IS_ON

char s[255];

va_list ap;

va_start(ap, format);