webrtc/base/criticalsection.h - Issue 2384693002: Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/criticalsection.h

Issue 2384693002: Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere (Closed)

Patch Set: !!! Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/criticalsection.h

diff --git a/webrtc/base/criticalsection.h b/webrtc/base/criticalsection.h

index bf77e2b78b64f99fc0f7ddf7299ad62d96baff0e..a0f9a6be814355532b4ea2652caca199832c41a1 100644

--- a/webrtc/base/criticalsection.h

+++ b/webrtc/base/criticalsection.h

@@ -12,6 +12,7 @@

#define WEBRTC_BASE_CRITICALSECTION_H_

#include "webrtc/base/atomicops.h"

+#include "webrtc/base/checks.h"

#include "webrtc/base/constructormagic.h"

#include "webrtc/base/thread_annotations.h"

#include "webrtc/base/platform_thread_types.h"

@@ -37,11 +38,7 @@

#include <dispatch/dispatch.h>

#endif

-#if (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON))

-#define CS_DEBUG_CHECKS 1

-#else

-#define CS_DEBUG_CHECKS 0

-#endif

+#define CS_DEBUG_CHECKS RTC_DCHECK_IS_ON

#if CS_DEBUG_CHECKS

#define CS_DEBUG_CODE(x) x

« no previous file with comments | « webrtc/base/checks.h ('k') | webrtc/base/sequenced_task_checker.h » ('j') | no next file with comments »