webrtc/api/statscollector.cc - Issue 2384693002: Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/statscollector.cc

Issue 2384693002: Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere (Closed)

Patch Set: !!! Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/statscollector.cc

diff --git a/webrtc/api/statscollector.cc b/webrtc/api/statscollector.cc

index 4dd53055288ef4fd7a0d93a9656f17076c5cd15d..766e94980384ceb32d91130edd2e2ee651b3f2e2 100644

--- a/webrtc/api/statscollector.cc

+++ b/webrtc/api/statscollector.cc

@@ -398,7 +398,7 @@ void StatsCollector::AddLocalAudioTrack(AudioTrackInterface* audio_track,

uint32_t ssrc) {

RTC_DCHECK(pc_->session()->signaling_thread()->IsCurrent());

RTC_DCHECK(audio_track != NULL);

-#if (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON))

+#if RTC_DCHECK_IS_ON

for (const auto& track : local_audio_tracks_)

RTC_DCHECK(track.first != audio_track || track.second != ssrc);

#endif

« no previous file with comments | « no previous file | webrtc/api/statstypes.cc » ('j') | no next file with comments »