Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: webrtc/common_audio/resampler/push_resampler.cc

Issue 2384693002: Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere (Closed)
Patch Set: !!! Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/thread_checker_unittest.cc ('k') | webrtc/media/sctp/sctpdataengine.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 11 matching lines...) Expand all
22 // These checks were factored out into a non-templatized function 22 // These checks were factored out into a non-templatized function
23 // due to problems with clang on Windows in debug builds. 23 // due to problems with clang on Windows in debug builds.
24 // For some reason having the DCHECKs inline in the template code 24 // For some reason having the DCHECKs inline in the template code
25 // caused the compiler to generate code that threw off the linker. 25 // caused the compiler to generate code that threw off the linker.
26 // TODO(tommi): Re-enable when we've figured out what the problem is. 26 // TODO(tommi): Re-enable when we've figured out what the problem is.
27 // http://crbug.com/615050 27 // http://crbug.com/615050
28 void CheckValidInitParams(int src_sample_rate_hz, int dst_sample_rate_hz, 28 void CheckValidInitParams(int src_sample_rate_hz, int dst_sample_rate_hz,
29 size_t num_channels) { 29 size_t num_channels) {
30 // The below checks are temporarily disabled on WEBRTC_WIN due to problems 30 // The below checks are temporarily disabled on WEBRTC_WIN due to problems
31 // with clang debug builds. 31 // with clang debug builds.
32 #if !defined(WEBRTC_WIN) && defined(__clang__) && !defined(NDEBUG) 32 #if !defined(WEBRTC_WIN) && defined(__clang__)
33 RTC_DCHECK_GT(src_sample_rate_hz, 0); 33 RTC_DCHECK_GT(src_sample_rate_hz, 0);
34 RTC_DCHECK_GT(dst_sample_rate_hz, 0); 34 RTC_DCHECK_GT(dst_sample_rate_hz, 0);
35 RTC_DCHECK_GT(num_channels, 0u); 35 RTC_DCHECK_GT(num_channels, 0u);
36 RTC_DCHECK_LE(num_channels, 2u); 36 RTC_DCHECK_LE(num_channels, 2u);
37 #endif 37 #endif
38 } 38 }
39 39
40 void CheckExpectedBufferSizes(size_t src_length, 40 void CheckExpectedBufferSizes(size_t src_length,
41 size_t dst_capacity, 41 size_t dst_capacity,
42 size_t num_channels, 42 size_t num_channels,
43 int src_sample_rate, 43 int src_sample_rate,
44 int dst_sample_rate) { 44 int dst_sample_rate) {
45 // The below checks are temporarily disabled on WEBRTC_WIN due to problems 45 // The below checks are temporarily disabled on WEBRTC_WIN due to problems
46 // with clang debug builds. 46 // with clang debug builds.
47 // TODO(tommi): Re-enable when we've figured out what the problem is. 47 // TODO(tommi): Re-enable when we've figured out what the problem is.
48 // http://crbug.com/615050 48 // http://crbug.com/615050
49 #if !defined(WEBRTC_WIN) && defined(__clang__) && !defined(NDEBUG) 49 #if !defined(WEBRTC_WIN) && defined(__clang__)
50 const size_t src_size_10ms = src_sample_rate * num_channels / 100; 50 const size_t src_size_10ms = src_sample_rate * num_channels / 100;
51 const size_t dst_size_10ms = dst_sample_rate * num_channels / 100; 51 const size_t dst_size_10ms = dst_sample_rate * num_channels / 100;
52 RTC_CHECK_EQ(src_length, src_size_10ms); 52 RTC_DCHECK_EQ(src_length, src_size_10ms);
53 RTC_CHECK_GE(dst_capacity, dst_size_10ms); 53 RTC_DCHECK_GE(dst_capacity, dst_size_10ms);
54 #endif 54 #endif
55 } 55 }
56 } 56 }
57 57
58 template <typename T> 58 template <typename T>
59 PushResampler<T>::PushResampler() 59 PushResampler<T>::PushResampler()
60 : src_sample_rate_hz_(0), 60 : src_sample_rate_hz_(0),
61 dst_sample_rate_hz_(0), 61 dst_sample_rate_hz_(0),
62 num_channels_(0) { 62 num_channels_(0) {
63 } 63 }
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 return static_cast<int>( 138 return static_cast<int>(
139 sinc_resampler_->Resample(src, src_length, dst, dst_capacity)); 139 sinc_resampler_->Resample(src, src_length, dst, dst_capacity));
140 } 140 }
141 } 141 }
142 142
143 // Explictly generate required instantiations. 143 // Explictly generate required instantiations.
144 template class PushResampler<int16_t>; 144 template class PushResampler<int16_t>;
145 template class PushResampler<float>; 145 template class PushResampler<float>;
146 146
147 } // namespace webrtc 147 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/base/thread_checker_unittest.cc ('k') | webrtc/media/sctp/sctpdataengine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698