Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1512)

Side by Side Diff: webrtc/base/stringutils.cc

Issue 2384693002: Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere (Closed)
Patch Set: !!! Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/sequenced_task_checker_unittest.cc ('k') | webrtc/base/thread_checker.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 size_t asccpyn(wchar_t* buffer, size_t buflen, 70 size_t asccpyn(wchar_t* buffer, size_t buflen,
71 const char* source, size_t srclen) { 71 const char* source, size_t srclen) {
72 if (buflen <= 0) 72 if (buflen <= 0)
73 return 0; 73 return 0;
74 74
75 if (srclen == SIZE_UNKNOWN) { 75 if (srclen == SIZE_UNKNOWN) {
76 srclen = strlenn(source, buflen - 1); 76 srclen = strlenn(source, buflen - 1);
77 } else if (srclen >= buflen) { 77 } else if (srclen >= buflen) {
78 srclen = buflen - 1; 78 srclen = buflen - 1;
79 } 79 }
80 #if !defined(NDEBUG) 80 #if RTC_DCHECK_IS_ON
81 // Double check that characters are not UTF-8 81 // Double check that characters are not UTF-8
82 for (size_t pos = 0; pos < srclen; ++pos) 82 for (size_t pos = 0; pos < srclen; ++pos)
83 RTC_DCHECK_LT(static_cast<unsigned char>(source[pos]), 128); 83 RTC_DCHECK_LT(static_cast<unsigned char>(source[pos]), 128);
84 #endif 84 #endif
85 std::copy(source, source + srclen, buffer); 85 std::copy(source, source + srclen, buffer);
86 buffer[srclen] = 0; 86 buffer[srclen] = 0;
87 return srclen; 87 return srclen;
88 } 88 }
89 89
90 #endif // WEBRTC_WIN 90 #endif // WEBRTC_WIN
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 std::string::size_type last = s.find_last_not_of(kWhitespace); 124 std::string::size_type last = s.find_last_not_of(kWhitespace);
125 125
126 if (first == std::string::npos || last == std::string::npos) { 126 if (first == std::string::npos || last == std::string::npos) {
127 return std::string(""); 127 return std::string("");
128 } 128 }
129 129
130 return s.substr(first, last - first + 1); 130 return s.substr(first, last - first + 1);
131 } 131 }
132 132
133 } // namespace rtc 133 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/sequenced_task_checker_unittest.cc ('k') | webrtc/base/thread_checker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698