Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Side by Side Diff: webrtc/base/sequenced_task_checker.h

Issue 2384693002: Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere (Closed)
Patch Set: !!! Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/criticalsection.h ('k') | webrtc/base/sequenced_task_checker_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_BASE_SEQUENCED_TASK_CHECKER_H_ 11 #ifndef WEBRTC_BASE_SEQUENCED_TASK_CHECKER_H_
12 #define WEBRTC_BASE_SEQUENCED_TASK_CHECKER_H_ 12 #define WEBRTC_BASE_SEQUENCED_TASK_CHECKER_H_
13 13
14 // Apart from debug builds, we also enable the sequence checker in 14 // Apart from debug builds, we also enable the sequence checker in
15 // builds with DCHECK_ALWAYS_ON so that trybots and waterfall bots 15 // builds with RTC_DCHECK_IS_ON so that trybots and waterfall bots
16 // with this define will get the same level of checking as debug bots. 16 // with this define will get the same level of checking as debug bots.
17 // 17 #define ENABLE_SEQUENCED_TASK_CHECKER RTC_DCHECK_IS_ON
18 // Note that this does not perfectly match situations where RTC_DCHECK is
19 // enabled. For example a non-official release build may have
20 // DCHECK_ALWAYS_ON undefined (and therefore SequencedTaskChecker would be
21 // disabled) but have RTC_DCHECKs enabled at runtime.
22 #if (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON))
23 #define ENABLE_SEQUENCED_TASK_CHECKER 1
24 #else
25 #define ENABLE_SEQUENCED_TASK_CHECKER 0
26 #endif
27 18
28 #include "webrtc/base/checks.h" 19 #include "webrtc/base/checks.h"
29 #include "webrtc/base/constructormagic.h" 20 #include "webrtc/base/constructormagic.h"
30 #include "webrtc/base/thread_annotations.h" 21 #include "webrtc/base/thread_annotations.h"
31 #include "webrtc/base/sequenced_task_checker_impl.h" 22 #include "webrtc/base/sequenced_task_checker_impl.h"
32 23
33 namespace rtc { 24 namespace rtc {
34 25
35 // Do nothing implementation, for use in release mode. 26 // Do nothing implementation, for use in release mode.
36 // 27 //
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 69
79 } // namespace internal 70 } // namespace internal
80 71
81 #define RTC_DCHECK_CALLED_SEQUENTIALLY(x) \ 72 #define RTC_DCHECK_CALLED_SEQUENTIALLY(x) \
82 rtc::internal::SequencedTaskCheckerScope checker(x) 73 rtc::internal::SequencedTaskCheckerScope checker(x)
83 74
84 #undef ENABLE_SEQUENCED_TASK_CHECKER 75 #undef ENABLE_SEQUENCED_TASK_CHECKER
85 76
86 } // namespace rtc 77 } // namespace rtc
87 #endif // WEBRTC_BASE_SEQUENCED_TASK_CHECKER_H_ 78 #endif // WEBRTC_BASE_SEQUENCED_TASK_CHECKER_H_
OLDNEW
« no previous file with comments | « webrtc/base/criticalsection.h ('k') | webrtc/base/sequenced_task_checker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698