Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere

webrtc/base/criticalsection.h

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_BASE_CRITICALSECTION_H_
 #define WEBRTC_BASE_CRITICALSECTION_H_
 
 #include "webrtc/base/atomicops.h"
+#include "webrtc/base/checks.h"
 #include "webrtc/base/constructormagic.h"
 #include "webrtc/base/thread_annotations.h"
 #include "webrtc/base/platform_thread_types.h"
 
 #if defined(WEBRTC_WIN)
 // Include winsock2.h before including <windows.h> to maintain consistency with
 // win32.h.  We can't include win32.h directly here since it pulls in
 // headers such as basictypes.h which causes problems in Chromium where webrtc
 // exists as two separate projects, webrtc and libjingle.
 #include <winsock2.h>
 #include <windows.h>
 #include <sal.h>  // must come after windows headers.
 #endif  // defined(WEBRTC_WIN)
 
 #if defined(WEBRTC_POSIX)
 #include <pthread.h>
 #endif
 
 // See notes in the 'Performance' unit test for the effects of this flag.
 #define USE_NATIVE_MUTEX_ON_MAC 0
 
 #if defined(WEBRTC_MAC) && !USE_NATIVE_MUTEX_ON_MAC
 #include <dispatch/dispatch.h>
 #endif
 
-#if (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON))
-#define CS_DEBUG_CHECKS 1
-#else
-#define CS_DEBUG_CHECKS 0
-#endif
+#define CS_DEBUG_CHECKS (!!RTC_DCHECK_IS_ON)

[ossu, 2016/09/30 09:08:49]

Why!!?
uhm
I mean, why "!!"? :)
Isn't RTC_DCHECK_IS_ON 0 or 1, just like CS_DEBUG_CHECKS should be? So just
define CS_DEBUG_CHECKS to RTC_DCHECK_IS_ON or possibly even replace
CS_DEBUG_CHECKS with a check against RTC_DCHECK_IS_ON?

[kwiberg-webrtc, 2016/09/30 09:14:21]

Will do (see other comment).

[kjellander_webrtc, 2016/09/30 10:42:28]

Ah, I was going to ask what (!!RTC_DCHECK_IS_ON) means, thanks for clarifying.

[kwiberg-webrtc, 2016/09/30 11:20:41]

Yes, ! maps 0 to 1 and all other values to 0, so !! maps 0 to 0 and all other
values to 1. It's a standard C idiom; in C++, you can also do pretty much the
same thing by casting to bool.

 
 #if CS_DEBUG_CHECKS
 #define CS_DEBUG_CODE(x) x
 #else  // !CS_DEBUG_CHECKS
 #define CS_DEBUG_CODE(x)
 #endif  // !CS_DEBUG_CHECKS
 
 namespace rtc {
 
 // Locking methods (Enter, TryEnter, Leave)are const to permit protecting
@@ skipping 90 matching lines @@
   explicit GlobalLockScope(GlobalLockPod* lock) EXCLUSIVE_LOCK_FUNCTION(lock);
   ~GlobalLockScope() UNLOCK_FUNCTION();
  private:
   GlobalLockPod* const lock_;
   RTC_DISALLOW_COPY_AND_ASSIGN(GlobalLockScope);
 };
 
 } // namespace rtc
 
 #endif // WEBRTC_BASE_CRITICALSECTION_H_