Relanding "Setting up an RTP input fuzzer for NetEq"

Relanding "Setting up an RTP input fuzzer for NetEq"

The original CL (https://codereview.webrtc.org/2315633002) was
reverted since the fuzzer depended on gflags and files in the
resources folder; neither of this is allowed for a fuzzer test in
Chromium. This new version streamlines the dependencies, and changes
the test to generate a sinusoid input audio signal instead of reading
from a file.

Original commit message:
This CL introduces a new fuzzer target neteq_rtp_fuzzer that
manipulates the RTP header fields before inserting the packets into
NetEq. A few helper classes are also introduced.

BUG=webrtc:5447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_chromium_rel_ng;master.tryserver.chromium.android:android_compile_dbg,linux_android_rel_ng;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.chromium.mac:mac_chromium_rel_ng,ios-device

Committed: https://crrev.com/58466f6d973fa7e0bbff870fe8c130e66b032860
Cr-Commit-Position: refs/heads/master@{#14523}

[hlundin-webrtc, 2016-10-04 08:06:08]

Break out neteq_test_minimal to new target

[hlundin-webrtc, 2016-10-04 08:06:20]

Patchset #3 (id:40001) has been deleted

[hlundin-webrtc, 2016-10-04 08:10:49]

henrik.lundin@webrtc.org changed reviewers:
+ ivoc@webrtc.org, kjellander@webrtc.org

[hlundin-webrtc, 2016-10-04 08:10:49]

Ivo, Henrik, please, take a look at this CL.

This is a relanding of the NetEq RTP fuzzer test. This is how the CL is built
up.

Patch set 1: Original CL (+ rebasing gn files)

Patch set 2: Change the test to generate an input signal as a sinusoid instead
of reading input from a file.

Patch set 3: Break out minimal test support needed.

I suggest that Ivo pays extra attention to PS2, while Henrik looks at PS3.

Thanks!

[kjellander_webrtc, 2016-10-04 10:09:57]

lgtm

[kjellander_webrtc, 2016-10-04 10:10:29]

On 2016/10/04 10:09:57, kjellander_webrtc wrote:
> lgtm

I suggest you run chromium trybots on this patch to be sure not breaking
chromium.webrtc.fyi bots.

[hlundin-webrtc, 2016-10-04 10:53:13]

On 2016/10/04 10:10:29, kjellander_webrtc wrote:
> On 2016/10/04 10:09:57, kjellander_webrtc wrote:
> > lgtm
> 
> I suggest you run chromium trybots on this patch to be sure not breaking
> chromium.webrtc.fyi bots.

Will do.

I cannot find any lubfuzzer trybots in chromium, but I did patch and compile
locally before uploading.

[kjellander_webrtc, 2016-10-04 11:38:32]

On 2016/10/04 10:53:13, hlundin-webrtc wrote:
> On 2016/10/04 10:10:29, kjellander_webrtc wrote:
> > On 2016/10/04 10:09:57, kjellander_webrtc wrote:
> > > lgtm
> > 
> > I suggest you run chromium trybots on this patch to be sure not breaking
> > chromium.webrtc.fyi bots.
> 
> Will do.
> 
> I cannot find any lubfuzzer trybots in chromium, but I did patch and compile
> locally before uploading.

I meant chromium.webrtc.fyi bots only, but I guess this didn't break them last
time - only the libfuzzer bots in chromium.fyi. I think they're working on
covering them with trybots (for that particular reason).

[hlundin-webrtc, 2016-10-04 12:57:54]

On 2016/10/04 11:38:32, kjellander_webrtc wrote:
> On 2016/10/04 10:53:13, hlundin-webrtc wrote:
> > On 2016/10/04 10:10:29, kjellander_webrtc wrote:
> > > On 2016/10/04 10:09:57, kjellander_webrtc wrote:
> > > > lgtm
> > > 
> > > I suggest you run chromium trybots on this patch to be sure not breaking
> > > chromium.webrtc.fyi bots.
> > 
> > Will do.
> > 
> > I cannot find any lubfuzzer trybots in chromium, but I did patch and compile
> > locally before uploading.
> 
> I meant chromium.webrtc.fyi bots only, but I guess this didn't break them last
> time - only the libfuzzer bots in chromium.fyi. I think they're working on
> covering them with trybots (for that particular reason).

Exactly. I took the example presets from
https://webrtc.org/contributing/#tryjobs-on-chromium-trybots. Seems green.

[ivoc, 2016-10-04 15:56:54]

lgtm.

https://codereview.webrtc.org/2384423002/diff/20001/webrtc/test/fuzzers/neteq...
File webrtc/test/fuzzers/neteq_rtp_fuzzer.cc (right):

https://codereview.webrtc.org/2384423002/diff/20001/webrtc/test/fuzzers/neteq...
webrtc/test/fuzzers/neteq_rtp_fuzzer.cc:50: double phase_ = 0.0f;
Should be 0.0 (no f).

[hlundin-webrtc, 2016-10-05 06:10:25]

Description was changed from

==========
Relanding "Setting up an RTP input fuzzer for NetEq"

The original CL (https://codereview.webrtc.org/2315633002) was
reverted since the fuzzer depended on gflags and files in the
resources folder; neither of this is allowed for a fuzzer test in
Chromium. This new version streamlines the dependencies, and changes
the test to generate a sinusoid input audio signal instead of reading
from a file.

Original commit message:
This CL introduces a new fuzzer target neteq_rtp_fuzzer that
manipulates the RTP header fields before inserting the packets into
NetEq. A few helper classes are also introduced.

BUG=webrtc:5447
==========

to

==========
Relanding "Setting up an RTP input fuzzer for NetEq"

The original CL (https://codereview.webrtc.org/2315633002) was
reverted since the fuzzer depended on gflags and files in the
resources folder; neither of this is allowed for a fuzzer test in
Chromium. This new version streamlines the dependencies, and changes
the test to generate a sinusoid input audio signal instead of reading
from a file.

Original commit message:
This CL introduces a new fuzzer target neteq_rtp_fuzzer that
manipulates the RTP header fields before inserting the packets into
NetEq. A few helper classes are also introduced.

BUG=webrtc:5447
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_rel_ng;tryserver.chromium.android:android_compile_dbg,linux_android_rel_ng;tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.chromium.mac:mac_chromium_rel_ng,ios-device
==========

[hlundin-webrtc, 2016-10-05 06:10:47]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-10-05 06:10:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, ivoc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2384423002/#ps120001 (title:
"Floating point literal in double precision")

[commit-bot: I haz the power, 2016-10-05 06:10:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-05 06:10:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 06:10:58]

Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.chromium.android
     tryserver.chromium.linux
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[hlundin-webrtc, 2016-10-05 06:12:55]

Description was changed from

==========
Relanding "Setting up an RTP input fuzzer for NetEq"

The original CL (https://codereview.webrtc.org/2315633002) was
reverted since the fuzzer depended on gflags and files in the
resources folder; neither of this is allowed for a fuzzer test in
Chromium. This new version streamlines the dependencies, and changes
the test to generate a sinusoid input audio signal instead of reading
from a file.

Original commit message:
This CL introduces a new fuzzer target neteq_rtp_fuzzer that
manipulates the RTP header fields before inserting the packets into
NetEq. A few helper classes are also introduced.

BUG=webrtc:5447
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_rel_ng;tryserver.chromium.android:android_compile_dbg,linux_android_rel_ng;tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.chromium.mac:mac_chromium_rel_ng,ios-device
==========

to

==========
Relanding "Setting up an RTP input fuzzer for NetEq"

The original CL (https://codereview.webrtc.org/2315633002) was
reverted since the fuzzer depended on gflags and files in the
resources folder; neither of this is allowed for a fuzzer test in
Chromium. This new version streamlines the dependencies, and changes
the test to generate a sinusoid input audio signal instead of reading
from a file.

Original commit message:
This CL introduces a new fuzzer target neteq_rtp_fuzzer that
manipulates the RTP header fields before inserting the packets into
NetEq. A few helper classes are also introduced.

BUG=webrtc:5447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_chromium_rel_ng;master.tryserver.chromium.android:android_compile_dbg,linux_android_rel_ng;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.chromium.mac:mac_chromium_rel_ng,ios-device
==========

[hlundin-webrtc, 2016-10-05 06:13:02]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-10-05 06:13:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kjellander_webrtc, 2016-10-05 06:38:11]

On 2016/10/05 06:13:08, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

I'm curious, did the CQ_INCLUDE_TRYBOTS entries get added automatically just
because you fired those Chromium trybots we talked about?
That entry shouldn't be needed but it's of course good if all those pass to
ensure we don't break Chromium.
We could add that whole entry to all our CLs, but then I need clear the
additional load that'll put on Chromium first with the Chrome infra team...

[hlundin-webrtc, 2016-10-05 06:51:35]

On 2016/10/05 06:38:11, kjellander_webrtc wrote:
> On 2016/10/05 06:13:08, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
> 
> I'm curious, did the CQ_INCLUDE_TRYBOTS entries get added automatically just
> because you fired those Chromium trybots we talked about?
> That entry shouldn't be needed but it's of course good if all those pass to
> ensure we don't break Chromium.
> We could add that whole entry to all our CLs, but then I need clear the
> additional load that'll put on Chromium first with the Chrome infra team...

No, I manually added them, because I wanted to try it out. Also, my first
attempt failed, since the instructions at
https://webrtc.org/contributing/#tryjobs-on-chromium-trybots didn't mention that
you have to prefix the tryserver names with master.*

[kjellander_webrtc, 2016-10-05 08:49:43]

On 2016/10/05 06:51:35, hlundin-webrtc wrote:
> On 2016/10/05 06:38:11, kjellander_webrtc wrote:
> > On 2016/10/05 06:13:08, commit-bot: I haz the power wrote:
> > > CQ is trying da patch. Follow status at
> > >  
> > >
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
> > 
> > I'm curious, did the CQ_INCLUDE_TRYBOTS entries get added automatically just
> > because you fired those Chromium trybots we talked about?
> > That entry shouldn't be needed but it's of course good if all those pass to
> > ensure we don't break Chromium.
> > We could add that whole entry to all our CLs, but then I need clear the
> > additional load that'll put on Chromium first with the Chrome infra team...
> 
> No, I manually added them, because I wanted to try it out. Also, my first
> attempt failed, since the instructions at
> https://webrtc.org/contributing/#tryjobs-on-chromium-trybots didn't mention
that
> you have to prefix the tryserver names with master.*

Ah, I updated that with https://github.com/webrtc/webrtc-org/pull/103
Thanks for pointing it out.

[commit-bot: I haz the power, 2016-10-05 09:27:43]

Description was changed from

==========
Relanding "Setting up an RTP input fuzzer for NetEq"

The original CL (https://codereview.webrtc.org/2315633002) was
reverted since the fuzzer depended on gflags and files in the
resources folder; neither of this is allowed for a fuzzer test in
Chromium. This new version streamlines the dependencies, and changes
the test to generate a sinusoid input audio signal instead of reading
from a file.

Original commit message:
This CL introduces a new fuzzer target neteq_rtp_fuzzer that
manipulates the RTP header fields before inserting the packets into
NetEq. A few helper classes are also introduced.

BUG=webrtc:5447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_chromium_rel_ng;master.tryserver.chromium.android:android_compile_dbg,linux_android_rel_ng;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.chromium.mac:mac_chromium_rel_ng,ios-device
==========

to

==========
Relanding "Setting up an RTP input fuzzer for NetEq"

The original CL (https://codereview.webrtc.org/2315633002) was
reverted since the fuzzer depended on gflags and files in the
resources folder; neither of this is allowed for a fuzzer test in
Chromium. This new version streamlines the dependencies, and changes
the test to generate a sinusoid input audio signal instead of reading
from a file.

Original commit message:
This CL introduces a new fuzzer target neteq_rtp_fuzzer that
manipulates the RTP header fields before inserting the packets into
NetEq. A few helper classes are also introduced.

BUG=webrtc:5447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_chromium_rel_ng;master.tryserver.chromium.android:android_compile_dbg,linux_android_rel_ng;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.chromium.mac:mac_chromium_rel_ng,ios-device
==========

[commit-bot: I haz the power, 2016-10-05 09:27:45]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-10-05 09:27:56]

Description was changed from

==========
Relanding "Setting up an RTP input fuzzer for NetEq"

The original CL (https://codereview.webrtc.org/2315633002) was
reverted since the fuzzer depended on gflags and files in the
resources folder; neither of this is allowed for a fuzzer test in
Chromium. This new version streamlines the dependencies, and changes
the test to generate a sinusoid input audio signal instead of reading
from a file.

Original commit message:
This CL introduces a new fuzzer target neteq_rtp_fuzzer that
manipulates the RTP header fields before inserting the packets into
NetEq. A few helper classes are also introduced.

BUG=webrtc:5447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_chromium_rel_ng;master.tryserver.chromium.android:android_compile_dbg,linux_android_rel_ng;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.chromium.mac:mac_chromium_rel_ng,ios-device
==========

to

==========
Relanding "Setting up an RTP input fuzzer for NetEq"

The original CL (https://codereview.webrtc.org/2315633002) was
reverted since the fuzzer depended on gflags and files in the
resources folder; neither of this is allowed for a fuzzer test in
Chromium. This new version streamlines the dependencies, and changes
the test to generate a sinusoid input audio signal instead of reading
from a file.

Original commit message:
This CL introduces a new fuzzer target neteq_rtp_fuzzer that
manipulates the RTP header fields before inserting the packets into
NetEq. A few helper classes are also introduced.

BUG=webrtc:5447
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_chromium_rel_ng;master.tryserver.chromium.android:android_compile_dbg,linux_android_rel_ng;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.chromium.mac:mac_chromium_rel_ng,ios-device

Committed: https://crrev.com/58466f6d973fa7e0bbff870fe8c130e66b032860
Cr-Commit-Position: refs/heads/master@{#14523}
==========

[commit-bot: I haz the power, 2016-10-05 09:27:56]

Patchset 6 (id:??) landed as
https://crrev.com/58466f6d973fa7e0bbff870fe8c130e66b032860
Cr-Commit-Position: refs/heads/master@{#14523}