Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: webrtc/api/rtcstatscollector.h

Issue 2384143002: RTCIceCandidateStats added. (Closed)
Patch Set: Addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/rtcstatscollector.cc » ('j') | webrtc/api/rtcstatscollector_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/rtcstatscollector.h
diff --git a/webrtc/api/rtcstatscollector.h b/webrtc/api/rtcstatscollector.h
index 2f5ed8610a6399fc57ea59bd085bcb9beadd08ac..6443d1323bfa5f8c1b8cb3ca823854ca3a0eef37 100644
--- a/webrtc/api/rtcstatscollector.h
+++ b/webrtc/api/rtcstatscollector.h
@@ -21,10 +21,12 @@
#include "webrtc/base/scoped_ref_ptr.h"
#include "webrtc/base/timeutils.h"
-namespace rtc {
+namespace cricket {
+class Candidate;
+} // namespace cricket
+namespace rtc {
class SSLCertificate;
-
} // namespace rtc
namespace webrtc {
@@ -76,12 +78,22 @@ class RTCStatsCollector : public virtual rtc::RefCountInterface {
void AddPartialResults_s(rtc::scoped_refptr<RTCStatsReport> partial_report);
void DeliverCachedReport();
+ // Produces |RTCCertificateStats|.
void ProduceCertificateStats_s(
int64_t timestamp_us, const SessionStats& session_stats,
RTCStatsReport* report) const;
void ProduceCertificateStatsFromSSLCertificateAndChain_s(
int64_t timestamp_us, const rtc::SSLCertificate& certificate,
RTCStatsReport* report) const;
+ // Produces |RTCIceCandidateStats|. TODO(hbos): Should also produce
+ // |RTCIceCandidatePairStats|. crbug.com/633550
+ void ProduceIceCandidateAndPairStats_s(
+ int64_t timestamp_us, const SessionStats& session_stats,
+ RTCStatsReport* report) const;
+ const std::string& ProduceIceCandidateStats_s(
+ int64_t timestamp_us, const cricket::Candidate& candidate, bool is_local,
+ RTCStatsReport* report) const;
+ // Produces |RTCPeerConnectionStats|.
void ProducePeerConnectionStats_s(
int64_t timestamp_us, RTCStatsReport* report) const;
@@ -105,6 +117,9 @@ class RTCStatsCollector : public virtual rtc::RefCountInterface {
rtc::scoped_refptr<const RTCStatsReport> cached_report_;
};
+// Helper function, exposed for unittests.
+const char* CandidateTypeToRTCIceCandidateType(const std::string& type);
+
} // namespace webrtc
#endif // WEBRTC_API_RTCSTATSCOLLECTOR_H_
« no previous file with comments | « no previous file | webrtc/api/rtcstatscollector.cc » ('j') | webrtc/api/rtcstatscollector_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698