webrtc/base/stringutils.cc - Issue 2384083004: Revert of Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/stringutils.cc

Issue 2384083004: Revert of Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/stringutils.cc

diff --git a/webrtc/base/stringutils.cc b/webrtc/base/stringutils.cc

index 48830e42338b4d4cf5660de53380a0e6fb3cc888..9580253d1b2f56e6a7e4a166720301d34217ca6e 100644

--- a/webrtc/base/stringutils.cc

+++ b/webrtc/base/stringutils.cc

@@ -77,7 +77,7 @@

} else if (srclen >= buflen) {

srclen = buflen - 1;

}

-#if RTC_DCHECK_IS_ON

+#if !defined(NDEBUG)

// Double check that characters are not UTF-8

for (size_t pos = 0; pos < srclen; ++pos)

RTC_DCHECK_LT(static_cast<unsigned char>(source[pos]), 128);

« no previous file with comments | « webrtc/base/sequenced_task_checker_unittest.cc ('k') | webrtc/base/thread_checker.h » ('j') | no next file with comments »