Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2383493005: Revert of Let ViEEncoder handle resolution changes. (Closed)

Created:
4 years, 2 months ago by perkj_webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Let ViEEncoder handle resolution changes. (patchset #17 id:340001 of https://codereview.webrtc.org/2351633002/ ) Reason for revert: Fails on a content_browsertest (and also webrtc_perf?) https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Tester/builds/34336 https://build.chromium.org/p/client.webrtc/builders/Linux64%20Release%20%5Blarge%20tests%5D/builds/9091/steps/webrtc_perf_tests/logs/stdio [ FAILED ] FullStackTest.ParisQcifWithoutPacketLoss (59436 ms) Original issue's description: > Let ViEEncoder handle resolution changes. > > This cl move codec reconfiguration due to video frame size changes from WebRtcVideoSendStream to ViEEncoder. > > With this change, many variables in WebRtcVideoSendStream no longer need to be locked. > > BUG=webrtc:5687, webrtc:6371, webrtc:5332 > > Committed: https://crrev.com/26105b41b4f97642ee30cb067dc786c2737709ad > Cr-Commit-Position: refs/heads/master@{#14445} TBR=sprang@webrtc.org,mflodman@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5687, webrtc:6371, webrtc:5332 Committed: https://crrev.com/3b703ede8b84267a4ff216aec9296e5dcdd7b6b7 Cr-Commit-Position: refs/heads/master@{#14447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+695 lines, -1155 lines) Patch
M webrtc/api/videocapturertracksource_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/call/bitrate_estimator_tests.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/call/call_perf_tests.cc View 7 chunks +11 lines, -41 lines 0 comments Download
M webrtc/call/rampup_tests.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/call/rampup_tests.cc View 2 chunks +7 lines, -31 lines 0 comments Download
M webrtc/config.h View 7 chunks +8 lines, -25 lines 0 comments Download
M webrtc/config.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M webrtc/media/base/fakevideocapturer.h View 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/media/engine/constants.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 3 chunks +6 lines, -15 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 2 chunks +45 lines, -25 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 24 chunks +258 lines, -243 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 11 chunks +50 lines, -53 lines 0 comments Download
M webrtc/test/call_test.h View 4 chunks +3 lines, -13 lines 0 comments Download
M webrtc/test/call_test.cc View 6 chunks +10 lines, -24 lines 0 comments Download
M webrtc/test/encoder_settings.h View 1 chunk +1 line, -32 lines 0 comments Download
M webrtc/test/encoder_settings.cc View 1 chunk +30 lines, -56 lines 0 comments Download
M webrtc/test/frame_generator.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/test/frame_generator.cc View 3 chunks +9 lines, -17 lines 0 comments Download
M webrtc/test/frame_generator_capturer.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/frame_generator_capturer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 19 chunks +89 lines, -158 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 2 chunks +14 lines, -4 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 28 chunks +56 lines, -239 lines 0 comments Download
M webrtc/video/vie_encoder.h View 4 chunks +1 line, -21 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 10 chunks +46 lines, -71 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 5 chunks +22 lines, -56 lines 0 comments Download
M webrtc/video_frame.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
perkj_webrtc
Created Revert of Let ViEEncoder handle resolution changes.
4 years, 2 months ago (2016-09-30 06:25:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2383493005/1
4 years, 2 months ago (2016-09-30 06:25:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 06:25:44 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 06:25:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b703ede8b84267a4ff216aec9296e5dcdd7b6b7
Cr-Commit-Position: refs/heads/master@{#14447}

Powered by Google App Engine
This is Rietveld 408576698