Restarting channel when swapping AudioReceiveStreams in WebrtcVoE.

Restarting channel when swapping AudioReceiveStreams in WebrtcVoE.

BUG=webrtc:6346
Committed: https://crrev.com/18e0b678159265b52de1fa7c3f4c9076b383bafd
Cr-Commit-Position: refs/heads/master@{#14493}

[aleloi, 2016-09-30 20:06:28]

Description was changed from

==========
Restarting channel when swapping AudioReceiveStreams in WebrtcVoE.

BUG=6346
==========

to

==========
Restarting channel when swapping AudioReceiveStreams in WebrtcVoE.

BUG=6346
==========

[aleloi, 2016-09-30 20:06:29]

aleloi@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[the sun, 2016-10-03 08:03:23]

Description was changed from

==========
Restarting channel when swapping AudioReceiveStreams in WebrtcVoE.

BUG=6346
==========

to

==========
Restarting channel when swapping AudioReceiveStreams in WebrtcVoE.

BUG=webrtc:6346
==========

[the sun, 2016-10-03 08:19:39]

lgtm, but check if there are any tests cases in webrtcvoiceengine_unittest.cc
that could be improved. (There's a FakeAudioReceiveStream which you can check
the started() attribute on: e.g. GetRecvStream(kSsrc2).started())

[aleloi, 2016-10-03 11:55:31]

https://codereview.webrtc.org/2383143002/diff/40001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/2383143002/diff/40001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine_unittest.cc:3356: 
I added a new test: There is currently no test that both starts playout and
makes a stream be recreated (tested by checking when Recreate is called and
playout_ is true) and was afraid to increase complexity of the existing tests.
What do you think?

[the sun, 2016-10-03 12:01:49]

lgtm % comments

https://codereview.webrtc.org/2383143002/diff/60001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/2383143002/diff/60001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine_unittest.cc:3344:
TEST_F(WebRtcVoiceEngineTestFake, ParametersShouldPreservePlayout) {
nit: Name is confusing - I don't see how the parameters (whoever they are) could
preserve playout. May I suggest "PreservePlayoutWhenRecreateRecvStream"... or if
you have a better suggestion?

https://codereview.webrtc.org/2383143002/diff/60001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine_unittest.cc:3346:
channel_->SetPlayout(true);
Add
EXPECT_TRUE(GetRecvStream(kSsrc1).started());

[aleloi, 2016-10-03 12:07:58]

https://codereview.webrtc.org/2383143002/diff/60001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine_unittest.cc (right):

https://codereview.webrtc.org/2383143002/diff/60001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine_unittest.cc:3344:
TEST_F(WebRtcVoiceEngineTestFake, ParametersShouldPreservePlayout) {
On 2016/10/03 12:01:49, the sun wrote:
> nit: Name is confusing - I don't see how the parameters (whoever they are)
could
> preserve playout. May I suggest "PreservePlayoutWhenRecreateRecvStream"... or
if
> you have a better suggestion?

I agree. I went with your proposal.

https://codereview.webrtc.org/2383143002/diff/60001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine_unittest.cc:3346:
channel_->SetPlayout(true);
On 2016/10/03 12:01:49, the sun wrote:
> Add
> EXPECT_TRUE(GetRecvStream(kSsrc1).started());

Done.

[aleloi, 2016-10-04 09:35:45]

The CQ bit was checked by aleloi@webrtc.org

[aleloi, 2016-10-04 09:35:45]

The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2383143002/#ps80001 (title:
"Minor changes in response to comments.")

[commit-bot: I haz the power, 2016-10-04 09:35:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-04 09:45:49]

Description was changed from

==========
Restarting channel when swapping AudioReceiveStreams in WebrtcVoE.

BUG=webrtc:6346
==========

to

==========
Restarting channel when swapping AudioReceiveStreams in WebrtcVoE.

BUG=webrtc:6346
==========

[commit-bot: I haz the power, 2016-10-04 09:45:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-04 09:46:00]

Description was changed from

==========
Restarting channel when swapping AudioReceiveStreams in WebrtcVoE.

BUG=webrtc:6346
==========

to

==========
Restarting channel when swapping AudioReceiveStreams in WebrtcVoE.

BUG=webrtc:6346

Committed: https://crrev.com/18e0b678159265b52de1fa7c3f4c9076b383bafd
Cr-Commit-Position: refs/heads/master@{#14493}
==========

[commit-bot: I haz the power, 2016-10-04 09:46:01]

Patchset 5 (id:??) landed as
https://crrev.com/18e0b678159265b52de1fa7c3f4c9076b383bafd
Cr-Commit-Position: refs/heads/master@{#14493}