Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: webrtc/media/base/testutils.h

Issue 2383093002: Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. (Closed)
Patch Set: Deleted a newline. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/base/testutils.h
diff --git a/webrtc/media/base/testutils.h b/webrtc/media/base/testutils.h
index 40034c0969a1709c1796dd41785544e288da1281..01a2a4f9c175d1a3456b36696242ad4779a040ea 100644
--- a/webrtc/media/base/testutils.h
+++ b/webrtc/media/base/testutils.h
@@ -29,6 +29,10 @@ class ByteBufferWriter;
class StreamInterface;
}
+namespace webrtc {
+class VideoFrame;
perkj_webrtc 2016/10/25 10:53:36 why forward declare? style guide recommend include
nisse-webrtc 2016/10/25 11:21:01 Really? Quoting https://chromium.googlesource.com/
perkj_webrtc 2016/10/27 15:56:25 interesting. I guess we follow chrome.
+}
+
namespace cricket {
// Returns size of 420 image with rounding on chroma for odd sizes.
@@ -115,7 +119,7 @@ class RtpTestUtility {
// Test helper for testing VideoCapturer implementations.
class VideoCapturerListener
: public sigslot::has_slots<>,
- public rtc::VideoSinkInterface<cricket::VideoFrame> {
+ public rtc::VideoSinkInterface<webrtc::VideoFrame> {
public:
explicit VideoCapturerListener(VideoCapturer* cap);
~VideoCapturerListener();
@@ -127,7 +131,7 @@ class VideoCapturerListener
bool resolution_changed() const { return resolution_changed_; }
void OnStateChange(VideoCapturer* capturer, CaptureState state);
- void OnFrame(const VideoFrame& frame) override;
+ void OnFrame(const webrtc::VideoFrame& frame) override;
private:
VideoCapturer* capturer_;

Powered by Google App Engine
This is Rietveld 408576698